Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ipython to 8.x #33530

Closed
mkoeppe opened this issue Mar 19, 2022 · 125 comments
Closed

Upgrade ipython to 8.x #33530

mkoeppe opened this issue Mar 19, 2022 · 125 comments
Labels
c: packages: standard p: critical / 2 t: enhancement
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 19, 2022

https://ipython.readthedocs.io/en/stable/whatsnew/version8.html

... and a number of related package updates.

See also: #33772 - update ipykernel

Depends on #33866
Depends on #33428

CC: @antonio-rojas @collares @tornaria @kiwifb @egourgoulhon @culler @NathanDunfield @dimpase

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: 1787e98

Reviewer: François Bissey, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/33530
@mkoeppe mkoeppe added this to the sage-9.7 milestone Mar 19, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

Changed dependencies from #32937, #33170 to #32937

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

Branch: u/mkoeppe/upgrade_ipython_to_8_x___requires_dropping_python_3_7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

Commit: b7e68d1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:5
[entrypoints-0.4] ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
[beautifulsoup4-4.11.1]   /Users/mkoeppe/s/sage/sage-rebasing/local/var/lib/sage/venv-python3.9/var/tmp/sage/build/beautifulsoup4-4.11.1/src/bs4/element.py:15: UserWarning: The soupsieve package is not installed. CSS selectors cannot be used.
[beautifulsoup4-4.11.1] ERROR: Could not find a version that satisfies the requirement soupsieve>1.2 (from beautifulsoup4) (from versions: none)
[attrs-21.4.0] WARNING: Ignoring invalid distribution -leach (/Users/mkoeppe/s/sage/sage-rebasing/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages)
[argon2_cffi-21.3.0] ERROR: Could not find a version that satisfies the requirement argon2-cffi-bindings (from argon2-cffi) (from versions: none)
[argon2_cffi-21.3.0] Warning: The installation needed to use "--no-deps --ignore-installed --ignore-requires-python" to succeed. This means that a dependencies file in build/pkgs/ needs to be updated. Please report this to [email protected], including the build log of this package.
[idna-3.3] requests 2.26.0 requires charset-normalizer~=2.0.0; python_version >= "3", which is not installed.
[appnope-0.1.3] ipython 7.29.0 requires decorator, which is not installed.
[appnope-0.1.3] ipython 7.29.0 requires prompt-toolkit!=3.0.0,!=3.0.1,<3.1.0,>=2.0.0, which is not installed.
[appnope-0.1.3] ipython 7.29.0 requires pygments, which is not installed.
[bleach-5.0.0] nbconvert 6.4.4 requires beautifulsoup4, which is not installed.
[bleach-5.0.0] nbconvert 6.4.4 requires entrypoints>=0.2.2, which is not installed.
[bleach-5.0.0] nbconvert 6.4.4 requires pygments>=2.4.1, which is not installed.

Last 10 new commits:

4a18b48build/pkgs/pyparsing: Update to 3.0.8
d06d988build/pkgs/pyrsistent: Update to 0.18.1
ef83bc4build/pkgs/pytz: Update to 2022.1
6871b5cbuild/pkgs/requests: Update to 2.27.1
5a91d17build/pkgs/snowballstemmer: Update to 2.2.0
0b6c066build/pkgs/testpath: Update to 0.6.0
24ec64cbuild/pkgs/tzlocal: Update to 4.2
88c7e93build/pkgs/urllib3: Update to 1.26.9
8f0cc2cbuild/pkgs/widgetsnbextension: Update to 3.6.0
b7e68d1build/pkgs/zipp: Update to 3.8.0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:6

After adding dependency soupsieve:

[soupsieve-2.3.2.post1] ModuleNotFoundError: No module named 'hatchling'

Also

[testpath-0.6.0] ERROR: Directory '.' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.
[jupyterlab_pygments-0.2.2] ModuleNotFoundError: No module named 'jupyter_packaging'
[tzlocal-4.2] ERROR: Could not find a version that satisfies the requirement pytz-deprecation-shim (from tzlocal) (from versions: none)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:7

Backing out the update of beautifulsoup4, argon2_cffi, jupyterlab_widgets

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

09e2d5bbuild/pkgs/requests: Update to 2.27.1
491c7babuild/pkgs/snowballstemmer: Update to 2.2.0
6a7b929build/pkgs/testpath: Update to 0.6.0
7a81948build/pkgs/tzlocal: Update to 4.2
274e707build/pkgs/urllib3: Update to 1.26.9
eb1ea4cbuild/pkgs/widgetsnbextension: Update to 3.6.0
5ab3fb5build/pkgs/zipp: Update to 3.8.0
c935a22build/pkgs/ipython/dependencies: Add decorator
2fffd00build/pkgs/entrypoints/spkg-install.in: Back out workaround for use of flit as the build system
fae6b2ebuild/pkgs/testpath/spkg-install.in: Back out workaround for use of flit as the build system

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from b7e68d1 to fae6b2e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:9
[nbformat-5.3.0] ERROR: Could not find a version that satisfies the requirement fastjsonschema (from nbformat) (from versions: none)
[tzlocal-4.2] ERROR: Could not find a version that satisfies the requirement pytz-deprecation-shim (from tzlocal) (from versions: none)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

5b13621build/pkgs/snowballstemmer: Update to 2.2.0
15812ccbuild/pkgs/testpath: Update to 0.6.0
efe0ff3build/pkgs/urllib3: Update to 1.26.9
319bcb2build/pkgs/widgetsnbextension: Update to 3.6.0
535c9cebuild/pkgs/zipp: Update to 3.8.0
585170abuild/pkgs/ipython/dependencies: Add decorator
fa8bf92build/pkgs/entrypoints/spkg-install.in: Back out workaround for use of flit as the build system
768ff59build/pkgs/testpath/spkg-install.in: Back out workaround for use of flit as the build system
66b406cbuild/pkgs/nbclient/dependencies: Add nbformat
e3d1b31build/pkgs/entrypoints/checksums.ini: Add upstream_url

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from fae6b2e to e3d1b31

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

19b9e7ebuild/pkgs/{entrypoints,pyparsing,testpath}/dependencies: Add flit_core tomli
b4b65b1build/pkgs/nbconvert/dependencies: Add markupsafe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from e3d1b31 to b4b65b1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:12
[nbconvert-6.5.0] ERROR: Could not find a version that satisfies the requirement MarkupSafe>=2.0 (from nbconvert) (from versions: 1.1.1)
[nbconvert-6.5.0] ERROR: No matching distribution found for MarkupSafe>=2.0

New commits:

19b9e7ebuild/pkgs/{entrypoints,pyparsing,testpath}/dependencies: Add flit_core tomli
b4b65b1build/pkgs/nbconvert/dependencies: Add markupsafe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from b4b65b1 to f41a3bf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

f41a3bfbuild/pkgs/ipykernel/checksums.ini: Fix upstream_url

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9317921build/pkgs/ipykernel/checksums.ini: Fix upstream_url

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from f41a3bf to 9317921

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:15
[ipykernel-6.13.0] Applying patches from ../patches...
[ipykernel-6.13.0] Applying ../patches/debugpy-make-optional.patch
[ipykernel-6.13.0] patching file pyproject.toml
[ipykernel-6.13.0] patching file setup.py
[ipykernel-6.13.0] Hunk #1 FAILED at 63.
[ipykernel-6.13.0] 1 out of 1 hunk FAILED -- saving rejects to file setup.py.rej
[ipykernel-6.13.0] Error applying '../patches/debugpy-make-optional.patch'

The patch from #33020 needs updating

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

5d90f80build/pkgs/urllib3: Update to 1.26.9
e26d28bbuild/pkgs/widgetsnbextension: Update to 3.6.0
b8a606fbuild/pkgs/zipp: Update to 3.8.0
b4bc216build/pkgs/ipython/dependencies: Add decorator
8f88e5abuild/pkgs/entrypoints/spkg-install.in: Back out workaround for use of flit as the build system
c32895dbuild/pkgs/testpath/spkg-install.in: Back out workaround for use of flit as the build system
9557455build/pkgs/nbclient/dependencies: Add nbformat
d043153build/pkgs/entrypoints/checksums.ini: Add upstream_url
1d69459build/pkgs/{entrypoints,pyparsing,testpath}/dependencies: Add flit_core tomli
89c65c2build/pkgs/nbconvert/dependencies: Add markupsafe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from 9317921 to 89c65c2

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:17

Backed out the ipykernel update for now.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 21, 2022

comment:18
[notebook-6.4.11] ERROR: Could not find a version that satisfies the requirement tinycss2 (from nbconvert) (from versions: none)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

8f042b4build/pkgs/urllib3: Update to 1.26.9
22a4488build/pkgs/widgetsnbextension: Update to 3.6.0
48046a5build/pkgs/zipp: Update to 3.8.0
ea79e97build/pkgs/ipython/dependencies: Add decorator
0c3619ebuild/pkgs/entrypoints/spkg-install.in: Back out workaround for use of flit as the build system
2ecff39build/pkgs/testpath/spkg-install.in: Back out workaround for use of flit as the build system
6108eb9build/pkgs/nbclient/dependencies: Add nbformat
d3d880fbuild/pkgs/entrypoints/checksums.ini: Add upstream_url
1a1e11fbuild/pkgs/{entrypoints,pyparsing,testpath}/dependencies: Add flit_core tomli
e33ca10build/pkgs/nbconvert/dependencies: Add markupsafe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 21, 2022

Changed commit from 89c65c2 to e33ca10

@GMS103
Copy link
Member

GMS103 commented Jul 14, 2022

comment:82

I am not sure this is relevant for this ticket, but for me make pyparsing fails persistently (unable to download package pyparsing-3.0.9.tar.gz from mirrors).

Log attached.

@GMS103
Copy link
Member

GMS103 commented Jul 14, 2022

Attachment: pyparsing-3.0.9.log

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 14, 2022

comment:83

You'll need configure --enable-download-from-upstream-url

@GMS103
Copy link
Member

GMS103 commented Jul 14, 2022

comment:84

Replying to @mkoeppe:

You'll need configure --enable-download-from-upstream-url

I did do it.

Now it is working (after the 29th mirror):

https://github.com/pyparsing/pyparsing/releases/download/pyparsing_3.0.9/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.lyrahosting.com/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://www-ftp.lip6.fr/pub/math/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.koddos.net/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.up.pt/pub/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.dogado.de/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://ftp.rediris.es/mirror/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.mit.edu/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.aliyun.com/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.yandex.ru/mirrors/sage.math.washington.edu/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://www.mirrorservice.org/sites/www.sagemath.org/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.xmission.com/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
http://files.sagemath.org/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.marwan.ma/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror-hk.koddos.net/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.csclub.uwaterloo.ca/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://ftp.sun.ac.za/ftp/pub/mirrors/www.sagemath.org/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.ufs.ac.za/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
http://linorg.usp.br/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://ftp.yz.yamagata-u.ac.jp/pub/math/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://ftp.riken.jp/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.rcg.sfu.ca/mirror/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirror.aarnet.edu.au/pub/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://sagemath.c3sl.ufpr.br/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://sage.mirror.garr.it/mirrors/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.nju.edu.cn/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.tuna.tsinghua.edu.cn/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://mirrors.ustc.edu.cn/sagemath/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
http://sagepad.org/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz
https://files.pythonhosted.org/packages/source/p/pyparsing/pyparsing-3.0.9.tar.gz

(before it got stuck at https://mirror.marwan.ma/sage/spkg/upstream/pyparsing/pyparsing-3.0.9.tar.gz).

@jhpalmieri
Copy link
Member

comment:85

That's how it's going to work when it is a new version of a Sage package: the mirrors currently only have an earlier version, so it tries and fails all of those before going to the upstream URL.

@jhpalmieri
Copy link
Member

Changed reviewer from François Bissey to none

@jhpalmieri
Copy link
Member

comment:86

I spot-checked again, a little more than last time. 3d plotting works well with various viewers, math in the notebook works. I don't see any issues.

@jhpalmieri
Copy link
Member

Reviewer: François Bissey, John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 14, 2022

comment:87

If searching the mirrors takes too long, you can edit upstream/mirror_list to make it shorter

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 14, 2022

comment:88

Thanks for the review!

@jhpalmieri
Copy link
Member

comment:89

Interrupt issues with this version of prompt_toolkit: see #33428.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2022

Changed dependencies from #33866 to #33866, #33428

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

bd1bc04build/pkgs/prompt_toolkit/install-requires.txt: Reject versions 3.0.25+
2a7059cMerge #33428
dbb63fabuild/pkgs/prompt_toolkit: Downgrade to 3.0.24

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2022

Changed commit from 2a7342f to dbb63fa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2022

Changed commit from dbb63fa to 1787e98

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 16, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

1787e98Merge tag '9.7.beta5' into t/33530/upgrade_ipython_to_8_x___requires_dropping_python_3_7

@jhpalmieri
Copy link
Member

comment:94

Looks good, thanks.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 16, 2022

comment:95

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 28, 2022

Changed branch from u/mkoeppe/upgrade_ipython_to_8_x___requires_dropping_python_3_7 to 1787e98

@vbraun vbraun closed this as completed in 8312ee1 Jul 28, 2022
dimpase pushed a commit to tornaria/sage that referenced this issue Feb 7, 2023
@mkoeppe
Merge sagemath#33530
0b71f8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
7 participants
@kiwifb @vbraun @culler @jhpalmieri @mkoeppe @antonio-rojas @GMS103