Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote linter errors about importing from "all" to warnings for now #33240

Closed
tobiasdiez opened this issue Jan 28, 2022 · 18 comments
Closed

Demote linter errors about importing from "all" to warnings for now #33240

tobiasdiez opened this issue Jan 28, 2022 · 18 comments

Comments

@tobiasdiez
Copy link
Contributor

The linter test about importing from "all"
currently fails for all tickets, thus hiding
new linting issues introduced in any ticket.

Until these imports are fixed,
demote the error to a warning.

CC: @mkoeppe @fchapoton

Component: build

Author: Tobias Diez

Branch: e7f3ed8

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/33240

@tobiasdiez tobiasdiez added this to the sage-9.5 milestone Jan 28, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

021d723Demote all import error to warning for now

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2022

Changed commit from 894a4e1 to 021d723

@fchapoton
Copy link
Contributor

comment:3

linter still fails

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2022

Changed commit from 021d723 to e7f3ed8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

e7f3ed8Fix lint error

@tobiasdiez
Copy link
Contributor Author

comment:5

Yes, since there was a real error hidden under the flood of these import issues. Since it was trivial to fix, let's do it also as part of this ticket.

@fchapoton
Copy link
Contributor

comment:6

ok, please fill the Author field

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@tobiasdiez
Copy link
Contributor Author

Author: Tobias Diez

@tobiasdiez
Copy link
Contributor Author

comment:7

Thanks for the quick review!

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 28, 2022

comment:8

This is a good solution. Didn't know about the "error: false" feature

@slel

This comment has been minimized.

@slel slel changed the title Demote all import error to warning for now Demote linter errors about importing from "all" to warnings for now Jan 29, 2022
@vbraun
Copy link
Member

vbraun commented Jan 30, 2022

Changed branch from public/build/fix_relint_all_imports to e7f3ed8

@fchapoton
Copy link
Contributor

comment:11

the linter is still broken, for all tickets based on 9.6.b1

@fchapoton
Copy link
Contributor

Changed commit from e7f3ed8 to none

@tobiasdiez
Copy link
Contributor Author

comment:12

This is unrelated to this ticket and a consequence of the six import introduced in #25633 and/or #33284.

@fchapoton
Copy link
Contributor

comment:13

is there a ticket for the fix ?

@fchapoton
Copy link
Contributor

comment:14

I have made #33350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants