-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demote linter errors about importing from "all" to warnings for now #33240
Comments
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:3
linter still fails |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Yes, since there was a real error hidden under the flood of these import issues. Since it was trivial to fix, let's do it also as part of this ticket. |
comment:6
ok, please fill the Author field |
Reviewer: Frédéric Chapoton |
Author: Tobias Diez |
comment:7
Thanks for the quick review! |
comment:8
This is a good solution. Didn't know about the "error: false" feature |
This comment has been minimized.
This comment has been minimized.
Changed branch from public/build/fix_relint_all_imports to |
comment:11
the linter is still broken, for all tickets based on 9.6.b1 |
Changed commit from |
comment:13
is there a ticket for the fix ? |
comment:14
I have made #33350 |
The linter test about importing from "all"
currently fails for all tickets, thus hiding
new linting issues introduced in any ticket.
Until these imports are fixed,
demote the error to a warning.
CC: @mkoeppe @fchapoton
Component: build
Author: Tobias Diez
Branch:
e7f3ed8
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/33240
The text was updated successfully, but these errors were encountered: