Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove traces of six #33350

Closed
fchapoton opened this issue Feb 15, 2022 · 9 comments
Closed

remove traces of six #33350

fchapoton opened this issue Feb 15, 2022 · 9 comments
Labels
p: critical / 2 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@fchapoton
Copy link
Contributor

CC: @tobiasdiez

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 5a6ba6c

Reviewer: Tobias Diez

Issue created by migration from https://trac.sagemath.org/ticket/33350
@fchapoton fchapoton added this to the sage-9.6 milestone Feb 15, 2022
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/33350

@fchapoton
Copy link
Contributor Author

New commits:

37c7557remove usage of six

@fchapoton
Copy link
Contributor Author

Commit: 37c7557

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5a6ba6cfix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 15, 2022

Changed commit from 37c7557 to 5a6ba6c

@fchapoton
Copy link
Contributor Author

comment:4

green linter, but red documentation. I can see no reason for the latter

please review swiftly !

@tobiasdiez
Copy link
Contributor

Reviewer: Tobias Diez

@tobiasdiez
Copy link
Contributor

comment:5

Documentation is now green (was temporary red because the second commit canceled the first run) and it works for me.

@vbraun
Copy link
Member

vbraun commented Feb 20, 2022

Changed branch from u/chapoton/33350 to 5a6ba6c

@vbraun vbraun closed this as completed in e4f9347 Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: critical / 2 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @tobiasdiez @fchapoton