-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sage.rings.abc.RealField, sage.rings.abc.ComplexField more #32742
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Dependencies: #32665 |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
comment:8
The doctest failure in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
LGTM. |
Reviewer: Travis Scrimshaw |
comment:15
Thank you! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:17
trivial merge |
Changed branch from u/mkoeppe/use_sage_rings_abc_realfield__sage_rings_abc_complexfield_more to |
As a follow-up on #32566 and #32610, we replace
isinstance
tests withRealField_class
by thesage.rings.abc.RealField
.git grep -E 'isinstance.*(Real|Complex)Field_class'
finds these uses.Depends on #32665
Depends on #32758
Depends on #32635
CC: @tobiasdiez @tscrim @EnderWannabe @bhutz
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
29e784b
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/32742
The text was updated successfully, but these errors were encountered: