Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sage.rings.abc.RealField, sage.rings.abc.ComplexField more #32742

Closed
mkoeppe opened this issue Oct 22, 2021 · 24 comments
Closed

Use sage.rings.abc.RealField, sage.rings.abc.ComplexField more #32742

mkoeppe opened this issue Oct 22, 2021 · 24 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 22, 2021

As a follow-up on #32566 and #32610, we replace isinstance tests with RealField_class by the sage.rings.abc.RealField.

git grep -E 'isinstance.*(Real|Complex)Field_class' finds these uses.

Depends on #32665
Depends on #32758
Depends on #32635

CC: @tobiasdiez @tscrim @EnderWannabe @bhutz

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 29e784b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32742

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 22, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

6dce213src/sage/schemes/projective/projective_morphism.py: Use sage.rings.abc
7e8f0bbsrc/sage/rings/real_double.pyx: Use sage.rings.abc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Commit: 7e8f0bb

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Changed commit from 7e8f0bb to a665529

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fbf6666src/sage/rings/continued_fraction.py: Use sage.rings.abc
9f17894src/sage/matrix/matrix_space.py: Use sage.rings.abc
2dd97basrc/sage/rings/asymptotic/asymptotic_ring.py: Use sage.rings.abc
41b7860src/sage/rings/convert/mpfi.pyx: Use sage.rings.abc
5d2e72csrc/sage/rings/infinity.py: Use sage.rings.abc
a665529src/sage/rings/polynomial/polynomial_ring.py: Use sage.rings.abc

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

Dependencies: #32665

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

fad87c0Expression.is_callable: New
4bc059bsrc/sage/ext/fast_callable.pyx: Remove use of is_CallableSymbolicExpression
8624925src/sage/symbolic/ring.pyx: Update doctest output with deprecation warning
37da733src/sage/sets/condition_set.py: Remove use of is_CallableSymbolicExpression
80a8f9esage.plot: Remove use of is_CallableSymbolicExpression, is_SymbolicEquation
a287531src/sage/schemes/elliptic_curves/constructor.py: Remove use of SR, is_SymbolicEquation; add test for symbolic input
c9861d1src/sage/interfaces/qepcad.py: Remove use of is_SymbolicEquation
341337asrc/sage/ext/fast_callable.pyx: Remove use of is_SymbolicVariable
1ee09aaMerge #32665
8c38bafsrc/sage/rings/continued_fraction.py: Add missing import

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 23, 2021

Changed commit from a665529 to 8c38baf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 23, 2021

comment:8

The doctest failure in integer.pyx is not from this ticket.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Changed dependencies from #32665 to #32665, #32758

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from 8c38baf to b3c1667

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c8499d1fix E713 and E714 in schemes
b3c1667Merge #32758

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Changed commit from b3c1667 to a1362ee

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 26, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ce8687bMerge #32612
15884f3src/sage/matrix/matrix_space.py: Import element classes on demand, fall back to generic on ImportError
ac58286Matrix.gram_schmidt: Use sage.rings.abc
6d4ee6eMatrix.gram_schmidt: Use sage.rings.abc (fixup)
a1362eeMerge #32635

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Changed dependencies from #32665, #32758 to #32665, #32758, #32635

@tscrim
Copy link
Collaborator

tscrim commented Oct 27, 2021

comment:14

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2021

comment:15

Thank you!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Changed commit from a1362ee to 29e784b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

29e784bMerge tag '9.5.beta5' into t/32742/use_sage_rings_abc_realfield__sage_rings_abc_complexfield_more

@sagetrac-git sagetrac-git mannequin removed the s: positive review label Oct 28, 2021
@sagetrac-git sagetrac-git mannequin added the s: needs review label Oct 28, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 28, 2021

comment:17

trivial merge

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

@vbraun vbraun closed this as completed in 89d2a53 Oct 31, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants