-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/setup.py: Don't cythonize everything in src/ #32672
Labels
Milestone
Comments
Author: Matthias Koeppe |
Commit: |
New commits:
|
Dependencies: #32673 |
This comment has been minimized.
This comment has been minimized.
Reviewer: Jonathan Kliem |
comment:7
LGTM. Btw, this is how I verified how it works.
In my case I placed |
comment:8
Thank you! |
Changed branch from u/mkoeppe/src_setup_py__don_t_cythonize_everything_in_src_ to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the version of setup.py used by the editable install:
at least it should restrict itself to
sage/**/*.pyx
so that it does not go cythonizing in random directories that the user may have in this directory... such as a venv...
Depends on #32673
CC: @tobiasdiez @kliem
Component: build
Author: Matthias Koeppe
Branch/Commit:
ff2a352
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/32672
The text was updated successfully, but these errors were encountered: