Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.geometry: Remove .all imports #32534

Closed
mkoeppe opened this issue Sep 19, 2021 · 22 comments
Closed

sage.geometry: Remove .all imports #32534

mkoeppe opened this issue Sep 19, 2021 · 22 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 19, 2021

as found by git grep 'all import' src/sage/geometry/

... in particular sage.rings.all, sage.modules.all, sage.misc.all, sage.categories.all, sage.matrix.all, because they will become namespace packages

Search/replace patterns useful for sage.geometry are applied throughout the Sage library.

Depends on #32386
Depends on #32416

CC: @kliem @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 6cbeaa6

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32534

@mkoeppe mkoeppe added this to the sage-9.5 milestone Sep 19, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

Commit: 8e357e1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

New commits:

0f2e375git grep -l 'all import ZZ' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import ZZ *$/sage.rings.integer_ring import ZZ/'
8a9ae7dgit grep -l 'all import QQ' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import QQ *$/sage.rings.rational_field import QQ/'
7b7cfc3git grep -l 'all import prod' src/sage | xargs sed -i.bak 's/sage[.]misc[.]all import prod *$/sage.misc.misc_c import prod/'
7955111git grep -l 'all import latex' src/sage | xargs sed -i.bak 's/sage[.]misc[.]all import latex *$/sage.misc.latex import latex/'
b693d89git grep -l 'all import vector' src/sage | xargs sed -i.bak 's/sage[.]modules[.]all import vector *$/sage.modules.free_module_element import vector/'
8e357e1git grep -l 'all import matrix' src/sage | xargs sed -i.bak 's/sage[.]matrix[.]all import matrix *$/sage.matrix.constructor import matrix/'

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2021

Changed commit from 8e357e1 to 2344514

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d070bffgit grep -l 'all import RDF' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import RDF *$/sage.rings.real_double import RDF/'
2344514git grep -l 'all import SR' src/sage | xargs sed -i.bak 's/sage.*[.]all import SR *$/sage.symbolic.ring import SR/'

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 19, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

b552ee8src/sage/geometry: Remove remaining imports from sage.all, sage.{rings,modules,misc,categories,matrix}.all

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 19, 2021

Changed commit from 2344514 to b552ee8

@kliem
Copy link
Contributor

kliem commented Sep 22, 2021

Reviewer: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Sep 22, 2021

comment:6

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 23, 2021

comment:7

Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2021

Changed commit from b552ee8 to 525c860

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 26, 2021

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

1d07a02Merge #32407
e9c8637get_sfunction_from_hash: Add doctest
712f926fix doctest getting source code
97060e9fix docbuild
5d062edone more doctest
3f1ac2esage.symbolic.expression: Merge new_Expression_from_pyobject and new_Expression_force_pyobject
0643756new_Expression_from_pyobject: Add output for new doctests
327ca5fMerge #32407
0d0b58fMerge tag '9.5.beta1' into t/32386/merge_pynac_as_src_sage_symbolic_ginac
525c860Merge #32386

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 26, 2021

comment:9

Merged #32386 to resolve merge conflict

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 26, 2021

Dependencies: #32386

@vbraun
Copy link
Member

vbraun commented Oct 9, 2021

comment:10

merge conflict

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 10, 2021

Changed dependencies from #32386 to #32386, #32416

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d3479c7remove some of symbolics from sage.geometry
ef19b5aMerge branch 'u/gh-kliem/remove_symbolics_from_geometry' of git://trac.sagemath.org/sage into u/gh-kliem/remove_symbolics_from_geometry
c40df1afix doctest
6cbeaa6Merge #32416

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 10, 2021

Changed commit from 525c860 to 6cbeaa6

@vbraun
Copy link
Member

vbraun commented Oct 10, 2021

Changed branch from u/mkoeppe/sage_geometry__remove__all_imports to 6cbeaa6

@vbraun vbraun closed this as completed in 3ca619a Oct 10, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants