-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update section "Sage Development Process" in Developer's Guide #29784
Comments
comment:1
It might be also helpful to add the steps from #25206 comment:63 to the documentation. |
comment:2
Indeed. Are you planning to work on this? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:7
Moving to 9.4, as 9.3 has been released. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: |
Author: Matthias Koeppe |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:17
Thanks for the update! Maybe in
by something like
|
comment:18
computer. ` This is only true if many packages come from the system. Of course building gcc takes more time... |
comment:51
Thanks for these welcome changes. Some lines are indented 3 spaces, maybe use 4 throughout? Suggested shorter rephrasing:
Positive review from me with or without these changes. |
Changed reviewer from Eric Gourgoulhon, Tobias Diez to Eric Gourgoulhon, Tobias Diez, Samuel Lelièvre |
comment:52
OK if you want to push this change to the ticket. |
comment:53
Replying to @tobiasdiez:
So do I. |
comment:54
Here are some changes to the README As listed in the commit message:
New commits:
|
Changed branch from u/mkoeppe/update_section__sage_development_process__in_developer_s_guide to u/slelievre/29784 |
This comment has been minimized.
This comment has been minimized.
comment:55
The command with this change does not work. "develop" must come right after "--branch" |
comment:56
And removing this breaks the workflow in the case of git
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:60
Better like this? |
comment:61
Yes, looking good, thanks |
comment:62
Could you please remove this spurious empty line in $ cd sage-x.y/ # adapt x.y
-
- [Git] Alternatively, clone the Sage git repository:
$ ORIG=https://github.com/sagemath/sage.git
It causes bad formatting in some markdown readers (e.g. abricotine). |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:64
Thanks! |
comment:65
Thanks everyone for review and edits! |
Changed branch from u/slelievre/29784 to |
(from #29733)
Let the documentation, in particular
the developer walk-through at
better reflect recent changes to the readme.
Mention that
make
takes very long.Add discussion of
make build
.Update Git instructions as discussed in
CC: @tobiasdiez @dimpase @jhpalmieri @slel @yuan-zhou @DavidAyotte @nbruin @egourgoulhon
Component: documentation
Author: Matthias Koeppe
Branch/Commit:
d04d123
Reviewer: Eric Gourgoulhon, Tobias Diez, Samuel Lelièvre
Issue created by migration from https://trac.sagemath.org/ticket/29784
The text was updated successfully, but these errors were encountered: