Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section "Sage Development Process" in Developer's Guide #29784

Closed
mkoeppe opened this issue Jun 2, 2020 · 79 comments
Closed

Update section "Sage Development Process" in Developer's Guide #29784

mkoeppe opened this issue Jun 2, 2020 · 79 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 2, 2020

(from #29733)

Let the documentation, in particular
the developer walk-through at

better reflect recent changes to the readme.

Mention that make takes very long.

Add discussion of make build.

Update Git instructions as discussed in

CC: @tobiasdiez @dimpase @jhpalmieri @slel @yuan-zhou @DavidAyotte @nbruin @egourgoulhon

Component: documentation

Author: Matthias Koeppe

Branch/Commit: d04d123

Reviewer: Eric Gourgoulhon, Tobias Diez, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/29784

@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 2, 2020
@tobiasdiez
Copy link
Contributor

comment:1

It might be also helpful to add the steps from #25206 comment:63 to the documentation.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 2, 2020

comment:2

Indeed. Are you planning to work on this?

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2021

comment:7

Moving to 9.4, as 9.3 has been released.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 May 10, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 11, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 27, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

831e3a7src/doc/en/developer/walk_through.rst: Remove duplicated (incomplete) build instructions
4c1d1f4src/doc/en/developer/walk_through.rst: Switch from 'make' to 'make build' for rebuilds

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Commit: 4c1d1f4

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 27, 2021

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7f00cbfREADME.md: Fix typo
5200907README.md: Remove link to 'Sage virtual appliance'

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Changed commit from 4c1d1f4 to 5200907

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

ff4d378README.md, src/doc/en/installation/source.rst: Reduce duplication of installation steps

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 27, 2021

Changed commit from 5200907 to ff4d378

@egourgoulhon
Copy link
Member

comment:17

Thanks for the update!

Maybe in README.md, replace

12. Type `make`.  That's it! Everything is automatic and
   non-interactive; but it will take a few hours (on a recent
   computer).

by something like

12. Type `make`.  That's it! Everything is automatic and
   non-interactive. NB: you can shorten the build time by typing instead 
   `MAKE='make -jNUM' make`, thereby telling the `make` program to run `NUM` jobs 
   in parallel. A recommended value for `NUM` is twice the number of cores of 
   your CPU. With `NUM` = 8, building Sage takes less than one hour on a modern 
   computer. 

@dimpase
Copy link
Member

dimpase commented Dec 27, 2021

comment:18

With NUM = 8, building Sage takes less than one hour on a modern

computer. `

This is only true if many packages come from the system. Of course building gcc takes more time...

@slel
Copy link
Member

slel commented Dec 28, 2021

comment:51

Thanks for these welcome changes.

Some lines are indented 3 spaces, maybe use 4 throughout?

Suggested shorter rephrasing:

-    * Compilers: `gcc`, `gfortran`, `g++` (a matching set of these
-      three will avoid the compilation of Sage-specific compilers -
-      unless they are too old).  See the Installation Manual for a
-      discussion of suitable compilers.
+    * Compilers: `gcc`, `gfortran`, `g++` (a recent enough matching
+      set of these three will avoid building Sage-specific compilers).
+      See the Installation Manual for a discussion of suitable compilers.

Positive review from me with or without these changes.

@slel
Copy link
Member

slel commented Dec 28, 2021

Changed reviewer from Eric Gourgoulhon, Tobias Diez to Eric Gourgoulhon, Tobias Diez, Samuel Lelièvre

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 28, 2021

comment:52

OK if you want to push this change to the ticket.

@egourgoulhon
Copy link
Member

comment:53

Replying to @tobiasdiez:

That's a very good idea, I like it!

So do I.

@slel
Copy link
Member

slel commented Dec 29, 2021

comment:54

Here are some changes to the README
(all in a single commit, sorry).

As listed in the commit message:

  • Adjust indentation
  • Merge steps 2 and 3 for consistency since the Git version
    of step 2 already changed into the Sage directory
  • Minor rephrasing, e.g.:
    • "to something not containing any non-alphanumeric characters"
      -> "to contain only alphanumeric characters"
    • "(a matching set of these three will avoid the compilation
      of Sage-specific compilers - unless they are too old)" ->
      "(a recent enough matching set of these three will avoid
      building Sage-specific compilers)."
  • Update required disk space to "at least 10 GB" (rather than 6)
  • Spell out some abbreviations (OSS license -> software license;
    NFS -> network file system; cd -> change directory)
  • Add --tags to git clone
  • Fix minor punctuation inconsistencies (use - for all lists
    instead of sometimes *, comma after opensuse, period after bc)
  • Expand the "try it out" item to suggest some things to try
  • Suggest bookmarking the local documentation in your browser
  • Add link to online list of Sage packages
  • Add optional step to add symlink to sage in /usr/local/bin

New commits:

cbd595329784: README.md: Fix indentation, minor updates

@slel
Copy link
Member

slel commented Dec 29, 2021

@slel
Copy link
Member

slel commented Dec 29, 2021

Changed commit from 2e2b3fc to cbd5953

@slel

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 29, 2021

comment:55
            $ ORIG=https://github.com/sagemath/sage.git
-            $ git clone -c core.symlinks=true --branch master $ORIG
+            $ git clone -c core.symlinks=true --branch --tags develop $ORIG

The command with this change does not work. "develop" must come right after "--branch"

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 29, 2021

comment:56

And removing this breaks the workflow in the case of git

-3. `cd` into the source/build directory:
-
-        $ cd sage*/
-

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

c6e23bb29786: README.md: Fix and

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Changed commit from cbd5953 to c6e23bb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

961551729784: README.md: Fix `--tags` and `cd`

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Changed commit from c6e23bb to 9615517

@slel
Copy link
Member

slel commented Dec 29, 2021

comment:60

Better like this?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 29, 2021

comment:61

Yes, looking good, thanks

@egourgoulhon
Copy link
Member

comment:62

Could you please remove this spurious empty line in README.md:

             $ cd sage-x.y/  # adapt x.y
 
-
     - [Git] Alternatively, clone the Sage git repository:
 
             $ ORIG=https://github.com/sagemath/sage.git

It causes bad formatting in some markdown readers (e.g. abricotine).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

d04d12329784: README.md: Remove extra blank lines

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 29, 2021

Changed commit from 9615517 to d04d123

@egourgoulhon
Copy link
Member

comment:64

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 29, 2021

comment:65

Thanks everyone for review and edits!

@vbraun
Copy link
Member

vbraun commented Jan 4, 2022

Changed branch from u/slelievre/29784 to d04d123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants