-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create gitattributes file specifying proper line endings #29733
Comments
comment:2
Could you also take a look at the documentation that we have related to this in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
Good point. I've changed the readme accordingly. (Btw, the documentation at https://doc.sagemath.org/html/en/developer/walk_through.html is not really reflecting some of the recent changes to the readme.) |
comment:5
Thanks, I've opened #29784 for that. |
comment:6
Replying to @tobiasdiez:
I think it's better to keep the |
comment:7
I probably miss something, but what's the purpose of the But if you think it would be helpful, I'll readd this of course. |
comment:8
Replying to @tobiasdiez:
Of course it's redundant but by including it, it is more obvious to beginning users what to change to get the "develop" branch. At this point they do not necessarily know about git, and I don't think the README is a place to educate them about it. Think of a user who used to unpack tarballs but is taking a tiny step into the scary git world. |
comment:9
In any case, removing it does not belong on this ticket. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Ok, I've readded it. |
Reviewer: Matthias Koeppe |
comment:13
Is there anything else to do from my side? |
comment:14
no, just be patient |
Changed branch from u/gh-tobiasdiez/gitattributes to |
Changed commit from |
comment:16
Could it be that this broke #30403? |
comment:17
and this is also breaking some of the gitlab workers, maybe ? |
If you checkout sage on Windows, the line endings are wrong (depending on the core.autocrlf setting).
This PR adds a .gitattributes file which specifies the correct line ending so that simply cloning sage results in the correct line ending for all files. See the following documentation for more information
https://code.visualstudio.com/docs/remote/troubleshooting#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files
Component: build
Author: Tobias Diez
Branch:
1f027c9
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/29733
The text was updated successfully, but these errors were encountered: