Upgrade to primecount 4.7 #27662

slel · 2019-04-14T18:02:11Z

This ticket is to upgrade to primecount 4.7, released 2019-04-17.

Starting with primecount 4.6, released 2019-04-13, the cmake
dependency is relaxed from ≥ 3.9 to ≥ 3.4 (discussed at #27487).

Tarball (to be renamed primecount-4.7.tar.gz):

https://github.com/kimwalisch/primecount/archive/v4.7.tar.gz

CC: @slel @vinklein @videlec @embray

Component: packages: optional

Keywords: upgrade, primecount

Author: Samuel Lelièvre, Vincent Delecroix

Branch/Commit: 4d06dee

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27662

The text was updated successfully, but these errors were encountered:

slel · 2019-04-14T18:03:05Z

Branch: u/slelievre/primecount-4.6

slel · 2019-04-14T18:04:43Z

Commit: df46a55

slel · 2019-04-14T18:04:43Z

comment:2

After applying the changes in this ticket, downloading the tarball, and running

$ sage -i primecount
$ make

testing on python3 gives:

$ ./sage -t --long --optional=sage,primecount src/sage/interfaces/primecount.pyx
Running doctests with ID 2019-04-14-19-52-42-57423cc3.
Git branch: primecount-4.6
Using --optional=primecount,sage
Doctesting 1 file.
sage -t --long --warn-long 81.8 src/sage/interfaces/primecount.pyx
**********************************************************************
File "src/sage/interfaces/primecount.pyx", line 108, in sage.interfaces.primecount.prime_pi_128
Failed example:
    prime_pi_128(1000)     # optional - primecount
Exception raised:
    Traceback (most recent call last):
      File "/opt/s/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 671, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/opt/s/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1095, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.primecount.prime_pi_128[1]>", line 1, in <module>
        prime_pi_128(Integer(1000))     # optional - primecount
      File "sage/interfaces/primecount.pyx", line 100, in sage.interfaces.primecount.prime_pi_128 (build/cythonized/sage/interfaces/primecount.cpp:1981)
        cpdef prime_pi_128(n):
      File "sage/interfaces/primecount.pyx", line 113, in sage.interfaces.primecount.prime_pi_128 (build/cythonized/sage/interfaces/primecount.cpp:1892)
        cdef cppstring s = str(n)
      File "stringsource", line 15, in string.from_py.__pyx_convert_string_from_py_std__in_string (build/cythonized/sage/interfaces/primecount.cpp:2448)
    TypeError: expected bytes, str found
**********************************************************************
1 item had failures:
   1 of   3 in sage.interfaces.primecount.prime_pi_128
    [16 tests, 1 failure, 0.05 s]
----------------------------------------------------------------------
sage -t --long --warn-long 81.8 src/sage/interfaces/primecount.pyx  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 0.1 seconds
    cpu time: 0.0 seconds
    cumulative wall time: 0.1 seconds

New commits:

`df46a55`	`Upgrade to primecount 4.6`

videlec · 2019-04-15T06:18:32Z

comment:3

Indeed, this is invalid Python 3 in Cython cdef cppstring s = str(n). Replacing str -> bytes is probably sufficient.

slel · 2019-04-17T08:40:40Z

comment:4

Thanks for the analysis. I'll make that change in src/sage/interfaces/primecount.pyx and push a branch.

slel · 2019-04-17T09:12:26Z

comment:5

Did you mean this?

diff --git a/src/sage/interfaces/primecount.pyx b/src/sage/interfaces/primecount.pyx
index e1ef2b6da1..f9f4f85c15 100644
--- a/src/sage/interfaces/primecount.pyx
+++ b/src/sage/interfaces/primecount.pyx
@@ -110,7 +110,7 @@ cpdef prime_pi_128(n):
         sage: nth_prime_128(2**65)   # not tested
         ?
     """
-    cdef cppstring s = str(n)
+    cdef cppstring s = bytes(n)
     cdef bytes ans
     sig_on()
     ans = primecount.pi(s)

This gives me the following doctest failure (with primecount 4.7):

$ ./sage -t --long --optional=sage,primecount src/sage/interfaces/primecount.pyx
Forcing sage-location, probably because a new package was installed.
Cleaning up, do not interrupt this.
Done cleaning.
Running doctests with ID 2019-04-17-11-08-04-ac57896a.
Git branch: primecount-4.7
Using --optional=primecount,sage
Doctesting 1 file.
sage -t --long --warn-long 81.8 src/sage/interfaces/primecount.pyx
**********************************************************************
File "src/sage/interfaces/primecount.pyx", line 108, in sage.interfaces.primecount.prime_pi_128
Failed example:
    prime_pi_128(1000)     # optional - primecount
Exception raised:
    Traceback (most recent call last):
      File "/opt/s/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 671, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/opt/s/sage/local/lib/python3.7/site-packages/sage/doctest/forker.py", line 1095, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.primecount.prime_pi_128[1]>", line 1, in <module>
        prime_pi_128(Integer(1000))     # optional - primecount
      File "sage/interfaces/primecount.pyx", line 100, in sage.interfaces.primecount.prime_pi_128 (build/cythonized/sage/interfaces/primecount.cpp:1981)
        cpdef prime_pi_128(n):
      File "sage/interfaces/primecount.pyx", line 115, in sage.interfaces.primecount.prime_pi_128 (build/cythonized/sage/interfaces/primecount.cpp:1903)
        sig_on()
    RuntimeError: Aborted
**********************************************************************
1 item had failures:
   1 of   3 in sage.interfaces.primecount.prime_pi_128
    [16 tests, 1 failure, 0.05 s]
----------------------------------------------------------------------
sage -t --long --warn-long 81.8 src/sage/interfaces/primecount.pyx  # 1 doctest failed
----------------------------------------------------------------------
Total time for all tests: 0.1 seconds
    cpu time: 0.0 seconds
    cumulative wall time: 0.1 seconds

videlec · 2019-04-18T22:31:12Z

comment:6

At least the error changed. It now looks weird and the traceback does not give a clue of what went wrong.

slel · 2019-04-24T20:45:53Z

Changed branch from u/slelievre/primecount-4.6 to u/slelievre/primecount-4.7

slel · 2019-04-24T20:46:49Z

comment:8

Here is the branch if anyone can look into it.

New commits:

`ff23d35`	`27662: primecount 4.7 with a py3 fix`

slel · 2019-04-24T20:46:49Z

Changed commit from df46a55 to ff23d35

videlec · 2019-04-25T05:45:07Z

New commits:

`27b52c9`	`Merge branch 'u/slelievre/primecount-4.7' of trac.sagemath.org:sage into TMP`
`616f7e6`	`fix string conversion`

videlec · 2019-04-25T05:45:07Z

Author: Samuel Lelièvre, Vincent Delecroix

videlec · 2019-04-25T05:45:07Z

Changed branch from u/slelievre/primecount-4.7 to u/vdelecroix/27662

videlec · 2019-04-25T05:45:07Z

Changed commit from ff23d35 to 616f7e6

sagetrac-git · 2019-04-25T05:46:37Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`172096d`	`27662: primecount 4.7 with a py3 fix`
`4d06dee`	`fix string conversion`

sagetrac-git · 2019-04-25T05:46:37Z

Changed commit from 616f7e6 to 4d06dee

dimpase · 2019-04-25T09:05:34Z

Reviewer: Dima Pasechnik

dimpase · 2019-04-25T09:05:34Z

comment:11

LGTM

dimpase · 2019-04-25T10:19:19Z

comment:12

Could someone please review #27487 ? This is very easy, if you have autotools installed.

vbraun · 2019-04-29T12:36:02Z

Changed branch from u/vdelecroix/27662 to 4d06dee

slel added this to the sage-8.8 milestone Apr 14, 2019

slel added c: packages: optional labels Apr 14, 2019

This comment has been minimized.

Sign in to view

slel changed the title ~~Upgrade to primecount 4.6~~ Upgrade to primecount 4.7 Apr 17, 2019

videlec added the s: needs review label Apr 25, 2019

dimpase added s: positive review and removed s: needs review labels Apr 25, 2019

vbraun removed the s: positive review label Apr 29, 2019

vbraun closed this as completed in 867c86c Apr 29, 2019

dimpase mentioned this issue May 6, 2019

spkg-configure.m4 for cmake #27487

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to primecount 4.7 #27662

Upgrade to primecount 4.7 #27662

slel commented Apr 14, 2019

slel commented Apr 14, 2019

slel commented Apr 14, 2019

slel commented Apr 14, 2019

videlec commented Apr 15, 2019

This comment has been minimized.

slel commented Apr 17, 2019

slel commented Apr 17, 2019

videlec commented Apr 18, 2019

slel commented Apr 24, 2019

slel commented Apr 24, 2019

slel commented Apr 24, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

sagetrac-git mannequin commented Apr 25, 2019

sagetrac-git mannequin commented Apr 25, 2019

dimpase commented Apr 25, 2019

dimpase commented Apr 25, 2019

dimpase commented Apr 25, 2019

vbraun commented Apr 29, 2019

Upgrade to primecount 4.7 #27662

Upgrade to primecount 4.7 #27662

Comments

slel commented Apr 14, 2019

slel commented Apr 14, 2019

slel commented Apr 14, 2019

slel commented Apr 14, 2019

videlec commented Apr 15, 2019

This comment has been minimized.

slel commented Apr 17, 2019

slel commented Apr 17, 2019

videlec commented Apr 18, 2019

slel commented Apr 24, 2019

slel commented Apr 24, 2019

slel commented Apr 24, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

videlec commented Apr 25, 2019

sagetrac-git mannequin commented Apr 25, 2019

sagetrac-git mannequin commented Apr 25, 2019

dimpase commented Apr 25, 2019

dimpase commented Apr 25, 2019

dimpase commented Apr 25, 2019

vbraun commented Apr 29, 2019