spkg-configure.m4 for cmake

[dimpase]

practically a copy of the one for patch

Depends on #27662

CC: @embray @kiwifb @slel @vinklein

Component: packages: optional

Author: Dima Pasechnik

Branch/Commit: 741de68

Reviewer: Erik Bray, Samuel Lelièvre, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/27487

[embray]

comment:2

Well, this system's cmake is < 3.11, so in this case it "worked" in that it refused to use my system cmake. I don't know how strict the 3.11 requirement is but I'm fine with leaving it for now.

I'll also test on a system with a newer cmake.

[embray]

comment:3

Apparently 3.11 is actually quite recent. Unless there's a specific need for it, let's try setting to just 3.0 and see how that goes (my Cygwin has 3.83.6.2 for example).

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

07b87cf

spkg-configure for cmake

[sagetrac-git]

Changed commit from bd93208 to 07b87cf

[dimpase]

comment:5

OK, now it's 3.0.

[dimpase]

comment:6

Are you still checking this? There is an extra complication here that cmake
keeps 3.x for long, issuing updates with numbers 3.x.y to them on a regular basis.
Perhaps it's better to go all the way to x big enough for the meaningful cases such as current cygwin etc.

[embray]

comment:7

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

[slel]

comment:8

Note: we upgraded to cmake 3.11.0 in #25109 because cmake 3.8.1 was
not enough to build primecount 4.3 (an optional package).

However, primecount 4.6 was released on 2019-04-13 and lowered the
requirement from cmake 3.9 to cmake 3.4, if I understand correctly.

[slel]

comment:9

See the primecount changelog
-- no tarball on the GitHub releases page yet.

[slel]

comment:10

Tarball now uploaded to GitHub. The upgrade to primecount 4.6 is tracked at #27662.

Consider cmake 3.4.3 (released 2016-01-25) rather than cmake 3.0.2 (released 2014-09-11).

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

741de68

spkg-configure for cmake

[sagetrac-git]

Changed commit from 07b87cf to 741de68

[dimpase]

comment:12

bumped up the minimal cmake version to 3.4.
Please review.

[embray]

comment:13

Okay, sounds good to me. Does this mean we still need to upgrade primecount though?

[videlec]

comment:14

Replying to @embray:

Okay, sounds good to me. Does this mean we still need to upgrade primecount though?

done at #27662

[dimpase]

Dependencies: #27662

[dimpase]

comment:16

To review:

• pull the branch
• make sure Sage's cmake is not installed. (make cmake-clean should do the job)
• make sure you have cmake (version 3.4 or better) installed on the box.
• run ./bootstrap (you nedd autotools, yes)
• run ./configure and inspect its output - you should see that cmake is marked as `not installed)
• to make sure this all works, try it on Upgrade to primecount 4.7 #27662 (or some other cmake-dependent Sage thing)

As this branch merely adds an spkg-configure.m4 file, there is no pressing need to have Sage's configure package updated. It will get in as soon as an update of the latter happens.

[videlec]

comment:17

At least, cmake-3.14.1 is successfully detected on arch.

[videlec]

Reviewer: Vincent Delecroix

[videlec]

comment:18

And sage -i primecount did not trigger cmake compilation!

Thank you.

[dimpase]

comment:19

Thanks!

[slel]

Changed reviewer from Vincent Delecroix to Erik Bray, Samuel Lelièvre, Vincent Delecroix

[vbraun]

Changed branch from u/dimpase/packages/cmakeconf to 741de68