-
-
Notifications
You must be signed in to change notification settings - Fork 482
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Trac #31278: widgetsnbextension should not depend on notebook
This dependency pulls in a full installation of the Jupyter notebook. {{{ notebook>=4.4.1->widgetsnbextension~=3.5.0->ipywidgets==7.5.1 }}} This is an obstacle to avoiding to build a copy of the jupyter notebook (connecting to a system jupyter notebook). The dependency is being removed in the widgetsnbextension 4.x series (currently alpha). We backport it to the stable release. URL: https://trac.sagemath.org/31278 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik
- Loading branch information
Showing
3 changed files
with
26 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.5.1 | ||
3.5.1.p0 |
24 changes: 24 additions & 0 deletions
24
build/pkgs/widgetsnbextension/patches/no-notebook-dep.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
commit 55bc3c93bf4310d4f4d9d02f2e51d1d65b7f6533 (HEAD -> 7.6.3-sage) | ||
Author: Sylvain Corlay <[email protected]> | ||
Date: Mon Oct 21 01:33:23 2019 +0200 | ||
|
||
Drop notebook dependency from widgetsnbextension | ||
|
||
diff --git a/widgetsnbextension/setup.py b/widgetsnbextension/setup.py | ||
index 866d82eb..88746f95 100644 | ||
--- a/setup.py | ||
+++ b/setup.py | ||
@@ -219,13 +219,5 @@ if 'setuptools' in sys.modules: | ||
from setuptools.command.develop import develop | ||
setup_args['cmdclass']['develop'] = js_prerelease(develop, strict=True) | ||
|
||
-setuptools_args = {} | ||
-install_requires = setuptools_args['install_requires'] = [ | ||
- 'notebook>=4.4.1', | ||
-] | ||
- | ||
-if 'setuptools' in sys.modules: | ||
- setup_args.update(setuptools_args) | ||
- | ||
if __name__ == '__main__': | ||
setup(**setup_args) |