Skip to content

Commit

Permalink
Trac #31278: widgetsnbextension should not depend on notebook
Browse files Browse the repository at this point in the history
This dependency pulls in a full installation of the Jupyter notebook.
{{{
notebook>=4.4.1->widgetsnbextension~=3.5.0->ipywidgets==7.5.1
}}}
This is an obstacle to avoiding to build a copy of the jupyter notebook
(connecting to a system jupyter notebook).

The dependency is being removed in the widgetsnbextension 4.x series
(currently alpha). We backport it to the stable release.

URL: https://trac.sagemath.org/31278
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik
  • Loading branch information
Release Manager committed Mar 9, 2021
2 parents 9b4fbe6 + 5141bc3 commit 8bf73f7
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/pkgs/widgetsnbextension/dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(PYTHON) | $(PYTHON_TOOLCHAIN) notebook jupyter_core
$(PYTHON) | $(PYTHON_TOOLCHAIN) jupyter_core

----------
All lines of this file are ignored except the first.
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/widgetsnbextension/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.5.1
3.5.1.p0
24 changes: 24 additions & 0 deletions build/pkgs/widgetsnbextension/patches/no-notebook-dep.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
commit 55bc3c93bf4310d4f4d9d02f2e51d1d65b7f6533 (HEAD -> 7.6.3-sage)
Author: Sylvain Corlay <[email protected]>
Date: Mon Oct 21 01:33:23 2019 +0200

Drop notebook dependency from widgetsnbextension

diff --git a/widgetsnbextension/setup.py b/widgetsnbextension/setup.py
index 866d82eb..88746f95 100644
--- a/setup.py
+++ b/setup.py
@@ -219,13 +219,5 @@ if 'setuptools' in sys.modules:
from setuptools.command.develop import develop
setup_args['cmdclass']['develop'] = js_prerelease(develop, strict=True)

-setuptools_args = {}
-install_requires = setuptools_args['install_requires'] = [
- 'notebook>=4.4.1',
-]
-
-if 'setuptools' in sys.modules:
- setup_args.update(setuptools_args)
-
if __name__ == '__main__':
setup(**setup_args)

0 comments on commit 8bf73f7

Please sign in to comment.