Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load system trusted root certs for rustls #369

Merged
merged 8 commits into from
Mar 12, 2022
Merged

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Jan 8, 2022

Add ability to use trusted root certificates from the OS with rustls automatically. This also might benefit from refactoring our SSL/TLS configuration APIs which always assumed the OS default TLS engine prior. That can be done separately.

Add ability to use trusted root certificates from the OS with rustls automatically.

This is a work-in-progress and very rough.
@sagebind sagebind mentioned this pull request Jan 8, 2022
4 tasks
@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #369 (c285578) into master (fad86fd) will decrease coverage by 0.17%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   79.59%   79.41%   -0.18%     
==========================================
  Files          52       52              
  Lines        3092     3119      +27     
==========================================
+ Hits         2461     2477      +16     
- Misses        631      642      +11     
Impacted Files Coverage Δ
src/config/mod.rs 73.82% <ø> (ø)
src/config/tls.rs 36.78% <26.31%> (ø)
src/config/request.rs 73.61% <100.00%> (-0.37%) ⬇️
tests/request_body.rs 100.00% <0.00%> (ø)
src/agent/selector.rs 76.13% <0.00%> (+0.55%) ⬆️
src/client.rs 80.07% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad86fd...c285578. Read the comment docs.

@sagebind sagebind added blocked feature A new feature! labels Jan 26, 2022
@sagebind sagebind added this to the 2.0.0 milestone Mar 12, 2022
@sagebind sagebind removed the blocked label Mar 12, 2022
@sagebind sagebind marked this pull request as ready for review March 12, 2022 16:22
@sagebind sagebind merged commit 79338ab into master Mar 12, 2022
@sagebind sagebind deleted the rustls-root-certs branch March 12, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant