Clear timer once it expires, else it is effectively repeating #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the timer "fires" once, we must clear it ourselves, curl does not clear it for us using the callback after calling `action`, only when it changes. After our curl-provided timeout has expired, fall back to our default timeout, or else we continue polling in a loop.
|
Thanks for looking into this! Your analysis sounds correct to me. 👍 |
sagebind
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the timer "fires" once, we must clear it ourselves, curl does not clear it for us using the callback after calling
action, only when it changes. After our curl-provided timeout has expired, fall back to our default timeout, or else we continue polling in a loop.Closes #348