Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of Expect header to be configured #340

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Conversation

sagebind
Copy link
Owner

Add a configuration option for changing how POST requests behave under HTTP/1.1 and the Expect: 100-continue request behavior. Allow the user to change the timeout to a different duration or to disable the header entirely.

Replaces #311.

Fixes #303.

Add a configuration option for changing how POST requests behave under HTTP/1.1 and the `Expect: 100-continue` request behavior. Allow the user to change the timeout to a different duration or to disable the header entirely.

Replaces #311.

Fixes #303.
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #340 (e0d6b34) into master (1aee4cc) will increase coverage by 0.27%.
The diff coverage is 97.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage   74.80%   75.07%   +0.27%     
==========================================
  Files          58       59       +1     
  Lines        3135     3174      +39     
==========================================
+ Hits         2345     2383      +38     
- Misses        790      791       +1     
Impacted Files Coverage Δ
src/config/mod.rs 74.12% <95.45%> (+3.87%) ⬆️
src/client.rs 73.30% <100.00%> (+0.38%) ⬆️
src/config/request.rs 75.34% <100.00%> (+0.69%) ⬆️
tests/expect.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aee4cc...e0d6b34. Read the comment docs.

@sagebind sagebind merged commit d71fea6 into master Aug 22, 2021
@sagebind sagebind deleted the expect-config branch August 22, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration to disable Expect Header being set by default
1 participant