Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flume with async-channel #318

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented Apr 6, 2021

Flume changes its minimum Rust version too often and also recently added a dependency chain involving longer compile times than ideal. Async-channel is comparable to flume for our use-case, is stable, and has a smaller dependency tree.

Flume changes its minimum Rust version too often and also recently added a dependency chain involving longer compile times than ideal. Async-channel is comparable to flume for our use-case, is stable, and has a smaller dependency tree.
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #318 (f2405ac) into master (0c47d7c) will not change coverage.
The diff coverage is 76.92%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   75.07%   75.07%           
=======================================
  Files          57       57           
  Lines        2993     2993           
=======================================
  Hits         2247     2247           
  Misses        746      746           
Impacted Files Coverage Δ
src/handler.rs 71.10% <66.66%> (ø)
src/agent/mod.rs 72.68% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c47d7c...f2405ac. Read the comment docs.

@sagebind sagebind merged commit 1673479 into master Apr 6, 2021
@sagebind sagebind deleted the replace-flume-with-async-channel branch April 6, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant