Make autocomplete value a prop #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What --- - Turn the autocomplete value on the `input` configurable by exposing it as a prop. Why --- So it can be customised, which can be necessary to help developers show or hide autocomplete forms as they wish.
|
Done deal, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
inputconfigurable by exposing itas a prop.
Why
So it can be customised, which can be necessary to help developers show
or hide autocomplete forms as they wish.
I stumbled upon this issue where I had an input labelled with the word
Primary, and Chrome automatically assumed it was a primary address it was asking for, ending up with the results being hidden behind the Chrome autofill menu. This makes it easy to get around that.