Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate sass, convert to css #1531

Merged
merged 9 commits into from
Feb 17, 2022

Conversation

sagalbot
Copy link
Owner

@sagalbot sagalbot commented Oct 22, 2021

  • SASS will be deprecated on v3
  • SASS files removed entirely on v4

  • translate properties to CSS variables
  • update docs
  • remove node-sass
  • remove sass-loader

@sagalbot sagalbot mentioned this pull request Oct 22, 2021
@sagalbot sagalbot marked this pull request as ready for review February 17, 2022 19:11
@sagalbot sagalbot merged commit 1ecf71a into master Feb 17, 2022
@sagalbot sagalbot deleted the feat/deprecate-sass-refactor-to-css-variables branch February 17, 2022 20:21
@github-actions
Copy link

🎉 This PR is included in version 3.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sagalbot
Copy link
Owner Author

This might've been my sloppiest merge in the whole projects history!

  • broke the webpack dev server
  • added non-dev dependency

🤦

sagalbot added a commit that referenced this pull request Feb 18, 2022
zainudinsainal pushed a commit to zainudinsainal/vue-select that referenced this pull request Mar 26, 2022
zainudinsainal pushed a commit to zainudinsainal/vue-select that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant