Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Authentihash() for instances w/o fd #47

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

flanfly
Copy link
Contributor

@flanfly flanfly commented Sep 13, 2022

Authentihash() silently fails for instances created with NewBytes().

Authentihash() silently fails for instances created with NewBytes().
@LordNoteworthy
Copy link
Member

Thanks for submetting the PR. In fact, when I was looking at the code of the NewBytes(), we forgot to set the file.f = f by the end of the function. Are you calling NewBytes() by any chance instead of New() ?

@flanfly
Copy link
Contributor Author

flanfly commented Sep 13, 2022

Are you calling NewBytes() by any chance instead of New() ?

I do.

@LordNoteworthy
Copy link
Member

I see, the reason why the code fails is because a missing file.f = f in NewBytes().

Can you update the PR with the suggestion above please ? You won't need the modification you made in the first commit.

Thanks.

@LordNoteworthy
Copy link
Member

Are you comfortable making the commit or you prefer that I do it myself ?

@LordNoteworthy
Copy link
Member

I will merge this then I will apply a small modification. Thank you so much for your contribution.

@LordNoteworthy LordNoteworthy merged commit 5b91000 into saferwall:main Sep 15, 2022
@LordNoteworthy LordNoteworthy added the bug Something isn't working label Sep 19, 2022
@LordNoteworthy
Copy link
Member

You can use the v1.3.3 tag to use this patch.

@flanfly
Copy link
Contributor Author

flanfly commented Sep 27, 2022

Hey @LordNoteworthy sorry for keeping you hanging. I was busy with other stuff. Thank you for taking care of it.

@flanfly flanfly deleted the fix-authentihash branch September 27, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants