Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the overlay of the PE file #37

Merged
merged 1 commit into from
Jun 28, 2022
Merged

feat: the overlay of the PE file #37

merged 1 commit into from
Jun 28, 2022

Conversation

wanglei-coder
Copy link
Contributor

No description provided.

LordNoteworthy
LordNoteworthy approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@LordNoteworthy LordNoteworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Totally useful.

I think we might need this to fix the issue of the wrong calculated authentihash.

overlay_test.go
TestOverlay{
overlayOffset: 1163264,
overlayLength: 15760,
md5str: "1f46295a513e744895a6acf1029e136f",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's pretty smart 👍

@LordNoteworthy LordNoteworthy added the enhancement New feature or request label Jun 28, 2022
@LordNoteworthy LordNoteworthy merged commit 0dcc6c4 into saferwall:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordNoteworthy LordNoteworthy LordNoteworthy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanglei-coder @LordNoteworthy