Fix admin search slow #1750
Merged
Fix admin search slow #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
force-pushed
the
fix-admin-search
branch
from
1bac157
to
db9a621
Compare
- Implement new AdvancedAdminSearchMixin - Don't convert every value to text for search, so DB indexes can be used - Change admin search from `iexact (=)` to `exact (==)`
Uxio0
force-pushed
the
fix-admin-search
branch
from
db9a621
to
95c3fe3
Compare
moisses89
requested changes
Nov 13, 2023
| """ | ||
|
|
||
| # Apply keyword searches. | ||
| print("HOLA") |
| @@ -26,7 +26,6 @@ class SafeMessageConfirmationAdmin(BinarySearchAdmin): | |||
| list_select_related = ("safe_message",) | |||
| ordering = ["-created"] | |||
| search_fields = [ | |||
| "=safe_message__safe", | |||
| "=owner", | |||
| "safe_message__description", | |||
There was a problem hiding this comment.
description was removed from filter, are you aware of this?
There was a problem hiding this comment.
Yes, it was not posible to search for text when using a JOIN, so there was an error here
- Implement new AdvancedAdminSearchMixin - Don't convert every value to text for search, so DB indexes can be used - Change admin search from `iexact (=)` to `exact (==)`
Uxio0
force-pushed
the
fix-admin-search
branch
from
8edbf47
to
363715c
Compare
moisses89
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iexact (=)toexact (==)