Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory when loading Safe addresses for ERC20 indexing #2301

Closed
Uxio0 opened this issue Oct 31, 2024 · 2 comments · Fixed by #2324
Closed

Improve memory when loading Safe addresses for ERC20 indexing #2301

Uxio0 opened this issue Oct 31, 2024 · 2 comments · Fixed by #2324
Assignees
@Uxio0
Labels
bug Something isn't working

Comments

@Uxio0
Copy link
Member

Uxio0 commented Oct 31, 2024

ERC20 indexing requires loading of all the Safe addresses to filter the events locally. Currently all addresses are loaded and checksummed, and for some networks with a lot of Safes it takes a lot of RAM. Maybe a more optimal way could be storing the addresses as bytes
@Uxio0 Uxio0 added the bug Something isn't working label Oct 31, 2024
@Uxio0 Uxio0 self-assigned this Oct 31, 2024
@DashaBochkar

This comment was marked as spam.

Sign in to view
Uxio0 added a commit that referenced this issue Nov 11, 2024
@Uxio0
Optimize load of ERC20 addresses
5ac6718 
- Closes #2301
@Uxio0 Uxio0 mentioned this issue Nov 11, 2024
Merged
@JagoFigueroa
Copy link

Hola! I have been transacting in mainnet, sepolia and polygon staging this morning and I've had no issues 😄 Un saludito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize load of ERC20 addresses safe-global/safe-transaction-service
3 participants
@Uxio0 @JagoFigueroa @DashaBochkar