Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor delegate endpoint signatures to use EIP712 #1989

Closed
Uxio0 opened this issue Apr 12, 2024 · 2 comments · Fixed by #2001
Closed

Refactor delegate endpoint signatures to use EIP712 #1989

Uxio0 opened this issue Apr 12, 2024 · 2 comments · Fixed by #2001
Assignees
Labels
breaking_change Breaking Change enhancement New feature or request

Comments

@Uxio0
Copy link
Member

Uxio0 commented Apr 12, 2024

Currently we require to sign a hash, which is really wrong, and we should refactor the delegate signature to use an EIP712, similar to what we do for the delete transactions endpoint.

@mjadach-iv
Copy link

mjadach-iv commented Apr 23, 2024

@JagoFigueroa
Copy link

Looks good to me after checking with Felipe. I have left the checks for the v1 endpoints to the mobile team as a staging build of the app is needed to verify that delegation is working as expected.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Breaking Change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants