Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /delegate endpoints to work with typed data signatures #3412

Open
DmitryBespalov opened this issue May 15, 2024 · 3 comments
Open

Update /delegate endpoints to work with typed data signatures #3412

DmitryBespalov opened this issue May 15, 2024 · 3 comments
Labels
Epic Bigger task wontfix This will not be worked on

Comments

@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented May 15, 2024

V2 endpoints use the EIP712 signTypedData for registering the notifications.

For reference:

The scope of changes includes:

  • changing the signing with on-device keys (imported or generated keys)
  • implementing new signing request & low-level device communication with ledger devices
  • sending the typed data request via wallet connect for signing (signTypedData_v4)
  • using keystone's "typed data" request message
  • updating the endpoints to the version 2 (getting, updating, deleting delegates)
@DmitryBespalov DmitryBespalov added the Epic Bigger task label May 22, 2024
@DmitryBespalov DmitryBespalov added the wontfix This will not be worked on label Jun 13, 2024
@DmitryBespalov
Copy link
Contributor Author

Decided to postpone migrating to the v2 because of incompatible data structure supporting only one chain_id for the same delegate address. That would lead to a signing issue where user would sign 1 request per supported network (in the worst case), or N requests according to the number of networks which safes are added in the app.

Closing this as won't fix now.

@njelich
Copy link

njelich commented Jun 16, 2024

@DmitryBespalov So should a person trying to integrate this use the old endpoint then?

@DmitryBespalov
Copy link
Contributor Author

@njelich for now, the v1 should work fine. New v2 endpoints would be usable once safe-global/safe-transaction-service#2081 is implemented

@DmitryBespalov DmitryBespalov reopened this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Bigger task wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants