Add missing chainId parameter

safe-global · Nov 7, 2024 · bd6310e · bd6310e
1 parent e90cc85
commit bd6310e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/safe_transaction_service/history/services/notification_service.py b/safe_transaction_service/history/services/notification_service.py
@@ -214,6 +214,7 @@ class DelegatePayload(TypedDict):
     delegator: str
     label: str
     expiryDateSeconds: Optional[int]
+    chainId: str
 
 
 def _build_delegate_payload(
@@ -240,6 +241,7 @@ def _build_delegate_payload(
         expiryDateSeconds=(
             int(instance.expiry_date.timestamp()) if instance.expiry_date else None
         ),
+        chainId=str(get_chain_id()),
     )
 
 

diff --git a/safe_transaction_service/history/tests/test_signals.py b/safe_transaction_service/history/tests/test_signals.py
@@ -211,6 +211,7 @@ def test_delegates_signals_are_correctly_fired(self, send_event_mock: MagicMock)
             "delegator": delegate_for_safe.delegator,
             "label": delegate_for_safe.label,
             "expiryDateSeconds": int(delegate_for_safe.expiry_date.timestamp()),
+            "chainId": str(EthereumNetwork.GANACHE.value),
         }
         send_event_mock.assert_called_with(new_delegate_user_payload)
 
@@ -224,6 +225,7 @@ def test_delegates_signals_are_correctly_fired(self, send_event_mock: MagicMock)
             "delegator": permanent_delegate_without_safe.delegator,
             "label": permanent_delegate_without_safe.label,
             "expiryDateSeconds": None,
+            "chainId": str(EthereumNetwork.GANACHE.value),
         }
         send_event_mock.assert_called_with(new_delegate_user_payload)
 
@@ -243,6 +245,7 @@ def test_delegates_signals_are_correctly_fired(self, send_event_mock: MagicMock)
             "delegator": delegate_to_update.delegator,
             "label": new_label,
             "expiryDateSeconds": int(new_expiry_date.timestamp()),
+            "chainId": str(EthereumNetwork.GANACHE.value),
         }
         send_event_mock.assert_called_with(updated_delegate_user_payload)
 
@@ -256,5 +259,6 @@ def test_delegates_signals_are_correctly_fired(self, send_event_mock: MagicMock)
             "delegator": delegate_to_delete.delegator,
             "label": delegate_to_delete.label,
             "expiryDateSeconds": int(delegate_to_delete.expiry_date.timestamp()),
+            "chainId": str(EthereumNetwork.GANACHE.value),
         }
         send_event_mock.assert_called_with(updated_delegate_user_payload)