Closes #246: Add warning for _msgSender (#287)

safe-global · Mar 24, 2021 · a34d45e · a34d45e
1 parent ac82f3a
commit a34d45e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/contracts/GnosisSafe.sol b/contracts/GnosisSafe.sol
@@ -21,7 +21,7 @@ contract GnosisSafe
 
     using GnosisSafeMath for uint256;
 
-    string public constant VERSION = "1.2.0";
+    string public constant VERSION = "1.3.0";
 
     // keccak256(
     //     "EIP712Domain(uint256 chainId,address verifyingContract)"

diff --git a/contracts/handler/HandlerContext.sol b/contracts/handler/HandlerContext.sol
@@ -7,6 +7,8 @@ pragma solidity >=0.7.0 <0.9.0;
 contract HandlerContext {
 
     // This function does not rely on a trusted forwarder. Use the returned value only to check information against the calling manager.
+    /// @notice This is only reliable in combination with a FallbackManager that supports this (e.g. Safe contract >=1.3.0). 
+    ///         When using this functionality make sure that the linked _manager (aka msg.sender) supports this.
     function _msgSender() internal pure returns (address sender) {
         // The assembly code is more direct than the Solidity version using `abi.decode`.
         assembly { sender := shr(96, calldataload(sub(calldatasize(), 20))) }