Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
mmv08 committed Jan 11, 2023
1 parent 1f8f495 commit 4696b02
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions contracts/proxies/GnosisSafeProxyFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ contract GnosisSafeProxyFactory {
return type(GnosisSafeProxy).creationCode;
}

/// @dev Allows to create a new proxy contact using CREATE2.
/// @dev Allows to create a new proxy contract using CREATE2.
/// This method is only meant as an utility to be called from other methods
/// @param _singleton Address of singleton contract. Must be deployed at the time of execution.
/// @param salt Create2 salt to use for calculating the address of the new proxy contract.
Expand All @@ -34,15 +34,11 @@ contract GnosisSafeProxyFactory {
require(address(proxy) != address(0), "Create2 call failed");
}

/// @dev Allows to create a new proxy contact and execute a message call to the new proxy within one transaction.
/// @dev Allows to create a new proxy contract and execute a message call to the new proxy within one transaction.
/// @param _singleton Address of singleton contract. Must be deployed at the time of execution.
/// @param initializer Payload for message call sent to new proxy contract.
/// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
function createProxyWithNonce(
address _singleton,
bytes memory initializer,
uint256 saltNonce
) public returns (GnosisSafeProxy proxy) {
function createProxyWithNonce(address _singleton, bytes memory initializer, uint256 saltNonce) public returns (GnosisSafeProxy proxy) {
// If the initializer changes the proxy address should change too. Hashing the initializer data is cheaper than just concatinating it
bytes32 salt = keccak256(abi.encodePacked(keccak256(initializer), saltNonce));
proxy = deployProxy(_singleton, salt);
Expand All @@ -56,7 +52,7 @@ contract GnosisSafeProxyFactory {
emit ProxyCreation(proxy, _singleton);
}

/// @dev Allows to create a new proxy contact that should exist only on 1 network (e.g. specific governance or admin accounts)
/// @dev Allows to create a new proxy contract that should exist only on 1 network (e.g. specific governance or admin accounts)
/// by including the chain id in the create2 salt. Such proxies cannot be created on other networks by replaying the transaction.
/// @param _singleton Address of singleton contract. Must be deployed at the time of execution.
/// @param initializer Payload for message call sent to new proxy contract.
Expand All @@ -79,7 +75,7 @@ contract GnosisSafeProxyFactory {
emit ProxyCreation(proxy, _singleton);
}

/// @dev Allows to create a new proxy contact, execute a message call to the new proxy and call a specified callback within one transaction
/// @dev Allows to create a new proxy contract, execute a message call to the new proxy and call a specified callback within one transaction
/// @param _singleton Address of singleton contract. Must be deployed at the time of execution.
/// @param initializer Payload for message call sent to new proxy contract.
/// @param saltNonce Nonce that will be used to generate the salt to calculate the address of the new proxy contract.
Expand Down

0 comments on commit 4696b02

Please sign in to comment.