Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #69

Closed
wants to merge 3 commits into from
Closed

Update README.md #69

wants to merge 3 commits into from

Conversation

mozrt2
Copy link

@mozrt2 mozrt2 commented Jul 2, 2023

  • Adjusted the link to the signature docs so the link works again with the new domain
  • Adjusted the definition of the EIP-712 scheme to include the "to" address, which seems to be required for the hash & corresponding signature to be valid (based on my review of the allowance contract, test file, and my own tests)

@mozrt2
Update README.md
0c8857d 
- Adjusted the link to the signature docs to the new domain
- Adjusted the definition of the EIP-712 scheme to include the "to" address, which seems to be required for the hash & corresponding signature to be valid based on my review of the allowance contract, test file, and my own tests
@mozrt2 mozrt2 mentioned this pull request Jul 8, 2023
Closed
@mmv08
Copy link
Member

mmv08 commented Oct 9, 2023

hey ser could you please fix the conflicts?

@mozrt2
Copy link
Author

mozrt2 commented Oct 13, 2023 •
edited
Loading

Hi, not sure how to do this as I can't approve your merge somehow. I've invited you to the forked repo now, let me know if that helps.

@mmv08
Copy link
Member

mmv08 commented Oct 13, 2023

Everything appears to be fixed on the upstream branch now, so is there a need for this pr?

@mozrt2 mozrt2 closed this Nov 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmv08 mmv08 mmv08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mozrt2 @mmv08