Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowance module: Release 0.1.1 #493

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Allowance module: Release 0.1.1 #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions modules/allowances/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Changelog

This changelog only contains changes starting from version 0.1.1

# Version 0.1.1

## Compiler settings

Solidity compiler: [0.7.6](https://github.com/ethereum/solidity/releases/tag/v0.7.6)

Solidity optimizer: disabled

## Expected addresses

- `AllowanceModule` at `0xAA46724893dedD72658219405185Fb0Fc91e091C`

## Changes

### General

#### Fix the EIP-712 transfer typehash

Issue: [#70](https://github.com/safe-global/safe-modules/issues/70)

The typehash for the transfer was incorrect, making it impossible to use the module with EIP-712 signatures.

#### Add a check for `resetTimeMin`

For recurring allowances, the `resetTimeMin` must be greater than 0. However, the check was missing, making it possible to specify a `resetTimeMin` of 0, resulting in a divide by zero error and the transaction consuming all gas.

The change was suggested by the [Ackee blockchain](https://ackee.xyz/) during the audit of the module.
2 changes: 1 addition & 1 deletion modules/allowances/contracts/AllowanceModule.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ interface ISafe {

contract AllowanceModule is SignatureDecoder {
string public constant NAME = "Allowance Module";
string public constant VERSION = "0.1.0";
string public constant VERSION = "0.1.1";

bytes32 public constant DOMAIN_SEPARATOR_TYPEHASH = 0x47e79534a245952e8b16893a336b85a3d9ea9fa8c573f3d803afb92a79469218;
// keccak256(
Expand Down
Binary file added modules/allowances/docs/ackee-blockchain-safe-allowance-module-report.pdf
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion modules/allowances/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@safe-global/safe-allowance-module",
"version": "1.0.0",
"version": "0.1.1",
"description": "Allowance module for the gnosis safe",
"keywords": [
"Ethereum",
Expand Down
Loading