Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowance module: Refactor Safe interface from GnosisSafe to Safe #489

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Aug 29, 2024

This PR:

  • Renames the GnosisSafe interface to just Safe

@mmv08 mmv08 requested a review from a team as a code owner August 29, 2024 09:06
@mmv08 mmv08 requested review from nlordell, akshay-ap and remedcu and removed request for a team August 29, 2024 09:06
@@ -4,7 +4,7 @@ pragma solidity >=0.7.0 <0.8.0;
import "./Enum.sol";
import "./SignatureDecoder.sol";

interface GnosisSafe {
interface Safe {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ISafe?

Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a small suggestion to use the I prefix to indicate it is an interface.

@mmv08 mmv08 merged commit e418cd8 into main Aug 29, 2024
2 checks passed
@mmv08 mmv08 deleted the allowance-module/rename-interface branch August 29, 2024 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants