Fix EIP-7212 Dev Node Docker Build #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker build for the Optimism version of Geth with 7212 support was failing in CI. It turns out that this is related to a recent release of Go 1.23 which is causing Ethereum Geth and forks (such as the Optimism fork we use) to not build. The fix it to pin to an older version of Golang (1.22 being the latest version that works). I also, in experimenting, updated the version of Optimism Geth we use to see if it would help - which it didn't, but decided to leave the change in anyhow (it is just a version bump to the source that we use to build and a small change to the patch file to account for the changed code).
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
Pull Request Test Coverage Report for Build 10404096596Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker build for the Optimism version of Geth with 7212 support was failing in CI. It turns out that this is related to a recent release of Go 1.23 which is causing Ethereum Geth and forks (such as the Optimism fork we use) to not build.
The fix it to pin to an older version of Golang (1.22 being the latest version that works). I also, in experimenting, updated the version of Optimism Geth we use to see if it would help - which it didn't, but decided to leave the change in anyhow (it is just a version bump to the source that we use to build and a small change to the patch file to account for the changed code).