Fix TypeScript Lints #478
Merged
Fix TypeScript Lints #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
|
Yes, we can verify the script by running it and seeing if it results in the same (or similar results with the gas output). |
|
Tested with Pimlico, and it seems to work: https://dashboard.tenderly.co/tx/base-sepolia/0x8793b68afdd3ef5cf47b693af61f368b80250f24ba94e6203d855a20b116d1be/gas-usage |
remedcu
approved these changes
Aug 12, 2024
|
Captured in #480. Since it is unrelated to this PR - I won't address it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some TS lints from the gas metering example.
I am not sure how to test my changes, should I just run the scripts (cc @remedcu).