Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for version 0.3.0 of the module contract #264

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Update changelog for version 0.3.0 of the module contract #264

merged 3 commits into from
Feb 16, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Feb 14, 2024 •
edited
Loading

This PR:

Questions:

  • Should we use the new 0.8.24 compiler?

@mmv08 mmv08 requested a review from a team as a code owner February 14, 2024 10:27
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team February 14, 2024 10:27
@coveralls
Copy link

coveralls commented Feb 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7919010436

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.923%
Totals Coverage Status
Change from base Build 7887095823: 0.0%
Covered Lines: 131
Relevant Lines: 155
💛 - Coveralls

@mmv08 mmv08 force-pushed the 230-update-changelog-for-safe-4337-module branch from 1edba86 to d5f6b80 Compare February 14, 2024 10:37
nlordell
nlordell reviewed Feb 14, 2024
View reviewed changes
modules/4337/CHANGELOG.md Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 14, 2024
View reviewed changes
modules/4337/CHANGELOG.md Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo the markdown link syntax.

@nlordell nlordell mentioned this pull request Feb 15, 2024
Closed
@mmv08 @nlordell
Update modules/4337/CHANGELOG.md
614bec6 
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@mmv08 mmv08 requested a review from nlordell February 15, 2024 13:59
@mmv08 @nlordell
Update modules/4337/CHANGELOG.md
e38fb1b 
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@mmv08 mmv08 force-pushed the 230-update-changelog-for-safe-4337-module branch from 2a4ca6b to e38fb1b Compare February 15, 2024 16:19
@nlordell
Copy link
Collaborator

Should we use the new 0.8.24 compiler?

I would say “no” - last time I checked, hardhat didn’t fully report the latest compiler version (although this may be fixed with #266).

@nlordell nlordell merged commit be9e572 into feature/entrypoint-v0.7 Feb 16, 2024
7 of 9 checks passed
@nlordell nlordell deleted the 230-update-changelog-for-safe-4337-module branch February 16, 2024 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
@mmv08
Copy link
Member Author

mmv08 commented Feb 16, 2024

Should we use the new 0.8.24 compiler?

I would say “no” - last time I checked, hardhat didn’t fully report the latest compiler version (although this may be fixed with #266).

IIRC the same warning was shown for 0.8.23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @nlordell