Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document supported entrypoint versions #259

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Document supported entrypoint versions #259

merged 1 commit into from
Feb 9, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Feb 8, 2024

This PR:

  • Partially solves Update Safe 4337 Module Documentation for EntryPoint 0.7.0 #231 (partially because the issue says 0.7.0 which isn't released yet)
  • I decided to include the supported entrypoint version and address in the changelog because the official deployment is tied to a certain entrypoint which, in my opinion, should be documented.

@mmv08 mmv08 requested a review from a team as a code owner February 8, 2024 16:14
@mmv08 mmv08 requested review from rmeissner, nlordell, akshay-ap and remedcu and removed request for a team February 8, 2024 16:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7832558515

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.673%
Totals Coverage Status
Change from base Build 7830603265: 0.0%
Covered Lines: 125
Relevant Lines: 143
💛 - Coveralls

@mmv08 mmv08 merged commit ed765e2 into main Feb 9, 2024
12 checks passed
@mmv08 mmv08 deleted the docs/entrypoint-version branch February 9, 2024 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@remedcu remedcu Awaiting requested review from remedcu remedcu is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @coveralls @nlordell