[M-01] Potential Obsolescence for Safe4337Module
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
force-pushed
the
audit/m-01-alternative
branch
from
1d1c33b to
ec52151
Compare
Pull Request Test Coverage Report for Build 7756231656
💛 - Coveralls |
nlordell
reviewed
Feb 2, 2024
mmv08
force-pushed
the
audit/m-01-alternative
branch
2 times, most recently
from
1035387 to
9a79d47
Compare
mmv08
force-pushed
the
audit/m-01-alternative
branch
from
9a79d47 to
2759608
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As vaguely explained by the OpenZeppelin team, the primary motivation for M-01 is not compatibility with unreleased versions but a more prompt awareness of the new potential changes in the ERC-4337 standard, as they deemed incompatibility with the standard as one of the leading security concerns for the protocol.
This PR presents an alternative solution for M-01 by adding a secondary e2e test job that uses an upstream version of the bundler for the test. This should test both the
Entrypoint <> ModuleAPI compatibility (because the bundler will deploy its own Entrypoint to the locally running geth chain) as well as the storage access rules. The test also runs on schedule (1st and 15th of each month)