Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L-02] Fix Misleading Comments in Contract Code #240

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[L-02] Fix Misleading Comments in Contract Code #240

merged 1 commit into from
Feb 7, 2024

Conversation

nlordell
Copy link
Collaborator

This PR addresses issue L-02 from the audit report.

In particular it fixes two comments that were found to be inaccurate:

  1. SUPPORTED_ENTRYPOINT NatSpec documentation
  2. Comment explaining which contract was responsible for appending the msg.sender as per ERC-2771.

Additionally, I went through other comments in Safe4337Module.sol for additional errors (but did not find any).

@nlordell nlordell requested a review from a team as a code owner January 26, 2024 14:42
@nlordell nlordell requested review from rmeissner, akshay-ap, mmv08 and remedcu and removed request for a team January 26, 2024 14:42
@nlordell nlordell added the audit review A PR to address an issue found during an audit label Jan 26, 2024
@nlordell nlordell merged commit 48ed5f3 into main Feb 7, 2024
10 checks passed
@nlordell nlordell deleted the audit/l-02 branch February 7, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@remedcu remedcu remedcu approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@mmv08 mmv08 Awaiting requested review from mmv08 mmv08 is a code owner automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
audit review A PR to address an issue found during an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlordell @remedcu