-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe 4337 Signer Launchpad #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the PR
Pull Request Test Coverage Report for Build 7193084547
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #149, follow-up to #182
This PR provides another approach to Safe initialization to accommodate for custom signers that are deployed along with the Safe. See #182 for more context.
This launchpad implementation is very specific to custom signers and introduces a new
IUniqueSignerFactory
interface that must be implemented to work with it. The name “unique” signer is not great, but named this way since for a given factory and some “signer data”, aISignatureVerifier
implementation will correspond to a unique address. In the example of P-256 and WebAuthn signers, this means a P-256 public key will correspond to a unique on-chain address with anISignatureVerifier
implementation.This implementation works by tying the Safe address to the
signerFactory
,signerData
and Safesetup
parameters. This means a couple of things:SafeProxyFactory
Implementation Notes
Currently, the implementation only supports a single signer, but can be changed to support multiple (by turning
signerFactory
andsignerData
into arrays).Downsides
The downsides of this implementation over #182 is that it is a solution very specific to deploying Safes with custom signing schemes that require additional contract deployments and not a general solution to complex Safe setups in the context of ERC-4337.