Increase branch Coverage #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
force-pushed
the
feature/increase-test-coverage
branch
from
b48baa4
to
d12a91f
Compare
Pull Request Test Coverage Report for Build 6626570558
💛 - Coveralls |
mmv08
approved these changes
Oct 24, 2023
| @@ -128,6 +127,22 @@ describe('EIP4337Module - Existing Safe', async () => { | |||
| expect(emittedRevert).to.be.true | |||
| }) | |||
|
|
|||
| it('executeUserOpWithErrorString should execute contract calls', async () => { | |||
There was a problem hiding this comment.
One thing I actually forgot to do in the executeUserOpWithErrorString PR is to add tests for it to the EIP4337ModuleNew.spec.ts 🙈 would be amazing if you add them
There was a problem hiding this comment.
Added - the revert propagation test was also missing which I added (asserting that the Safe gets deployed even if the user op reverts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #87
This PR adds unit tests to cover the remaining branches from the
SimpleEIP4337Modulecontract. With this, we should have 100% coverage for the core contracts in the repo (although, not all paths in the test contracts are covered, which should be fine).In terms of test organisation, I added a
EIP4337Module.spec.tsfor unit tests directly targeting the module functions (validateUserOpandexecUserOp*).