Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new PackedUserOperation struct with packed gas fields from entrypoint 0.7.0 #225

Closed
mmv08 opened this issue Jan 25, 2024 · 0 comments
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented Jan 25, 2024

In the upcoming 0.7.0 release of the EntryPoint contract, gas fields in the UserOperation struct will be changed:

The change - [Added validatePaymasterUserOp and postOp gas limits.](https://github.com/eth-infinitism/account-abstraction/pull/363]
image

Update the 4337 module contract and tests to prepare for the upcoming change

nlordell added a commit that referenced this issue Feb 12, 2024
**This PR**:
- Addresses the M-01 from the audit by updating the ERC-4337 contracts
to the latest ones from the development branch (presumably, they will be
released as version 0.7.0). The most notable change is the new
`PackedUserOperation` struct with the new packed gas limit field
`accountGasLimits` that consists of two `uint128` packed values
`(validationGasLimit, callGasLimit)`
- Implements #225

Forked contracts repo with build artifacts:
https://github.com/5afe/account-abstraction
More about 0.7.0 changes:
#215

**Issues/concerns**:
- Using unaudited non-release candidate contract versions
- The reference bundler is still in development, thus e2e tests are
failing (Confirmed with ERC4337 team)

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@mmv08 mmv08 closed this as completed Feb 14, 2024
nlordell added a commit that referenced this issue Feb 23, 2024
**This PR**:
- Addresses the M-01 from the audit by updating the ERC-4337 contracts
to the latest ones from the development branch (presumably, they will be
released as version 0.7.0). The most notable change is the new
`PackedUserOperation` struct with the new packed gas limit field
`accountGasLimits` that consists of two `uint128` packed values
`(validationGasLimit, callGasLimit)`
- Implements #225

Forked contracts repo with build artifacts:
https://github.com/5afe/account-abstraction
More about 0.7.0 changes:
#215

**Issues/concerns**:
- Using unaudited non-release candidate contract versions
- The reference bundler is still in development, thus e2e tests are
failing (Confirmed with ERC4337 team)

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
nlordell added a commit that referenced this issue Mar 5, 2024
**This PR**:
- Addresses the M-01 from the audit by updating the ERC-4337 contracts
to the latest ones from the development branch (presumably, they will be
released as version 0.7.0). The most notable change is the new
`PackedUserOperation` struct with the new packed gas limit field
`accountGasLimits` that consists of two `uint128` packed values
`(validationGasLimit, callGasLimit)`
- Implements #225

Forked contracts repo with build artifacts:
https://github.com/5afe/account-abstraction
More about 0.7.0 changes:
#215

**Issues/concerns**:
- Using unaudited non-release candidate contract versions
- The reference bundler is still in development, thus e2e tests are
failing (Confirmed with ERC4337 team)

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
nlordell added a commit that referenced this issue Mar 5, 2024
**This PR**:
- Addresses the M-01 from the audit by updating the ERC-4337 contracts
to the latest ones from the development branch (presumably, they will be
released as version 0.7.0). The most notable change is the new
`PackedUserOperation` struct with the new packed gas limit field
`accountGasLimits` that consists of two `uint128` packed values
`(validationGasLimit, callGasLimit)`
- Implements #225

Forked contracts repo with build artifacts:
https://github.com/5afe/account-abstraction
More about 0.7.0 changes:
#215

**Issues/concerns**:
- Using unaudited non-release candidate contract versions
- The reference bundler is still in development, thus e2e tests are
failing (Confirmed with ERC4337 team)

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
nlordell added a commit that referenced this issue Mar 5, 2024
**This PR**:
- Addresses the M-01 from the audit by updating the ERC-4337 contracts
to the latest ones from the development branch (presumably, they will be
released as version 0.7.0). The most notable change is the new
`PackedUserOperation` struct with the new packed gas limit field
`accountGasLimits` that consists of two `uint128` packed values
`(validationGasLimit, callGasLimit)`
- Implements #225

Forked contracts repo with build artifacts:
https://github.com/5afe/account-abstraction
More about 0.7.0 changes:
#215

**Issues/concerns**:
- Using unaudited non-release candidate contract versions
- The reference bundler is still in development, thus e2e tests are
failing (Confirmed with ERC4337 team)

---------

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant