-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allowance module: Release 0.1.1 (#493)
This PR makes the necessary preparations for the long-awaited release of the allowance module. - Adds changelog - Adds the audit report from Ackee - Changes version numbers
- Loading branch information
Showing
4 changed files
with
33 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Changelog | ||
|
||
This changelog only contains changes starting from version 0.1.1 | ||
|
||
# Version 0.1.1 | ||
|
||
## Compiler settings | ||
|
||
Solidity compiler: [0.7.6](https://github.com/ethereum/solidity/releases/tag/v0.7.6) | ||
|
||
Solidity optimizer: disabled | ||
|
||
## Expected addresses | ||
|
||
- `AllowanceModule` at `0xAA46724893dedD72658219405185Fb0Fc91e091C` | ||
|
||
## Changes | ||
|
||
### General | ||
|
||
#### Fix the EIP-712 transfer typehash | ||
|
||
Issue: [#70](https://github.com/safe-global/safe-modules/issues/70) | ||
|
||
The typehash for the transfer was incorrect, making it impossible to use the module with EIP-712 signatures. | ||
|
||
#### Add a check for `resetTimeMin` | ||
|
||
For recurring allowances, the `resetTimeMin` must be greater than 0. However, the check was missing, making it possible to specify a `resetTimeMin` of 0, resulting in a divide by zero error and the transaction consuming all gas. | ||
|
||
The change was suggested by the [Ackee blockchain](https://ackee.xyz/) during the audit of the module. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+480 KB
modules/allowances/docs/ackee-blockchain-safe-allowance-module-report.pdf
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters