Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3404 Updated transaction type #3405

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3404

Changes proposed in this pull request:

  • Transaction list
  • Transaction details

- Transaction list
- Transaction details
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 8.27%. Comparing base (bb844ac) to head (2cd3462).
Report is 1 commits behind head on main.

Files Patch % Lines
...sViewController/TransactionDetailCellBuilder.swift 0.00% 6 Missing ⚠️
...ViewController/TransactionListViewController.swift 0.00% 3 Missing ⚠️
...n/WCIncomingTransactionRequestViewController.swift 0.00% 3 Missing ⚠️
...rvices/Safe Client Gateway Service/SCGModels.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3405      +/-   ##
========================================
- Coverage   8.27%   8.27%   -0.01%     
========================================
  Files        788     788              
  Lines      44084   44098      +14     
========================================
+ Hits        3647    3648       +1     
- Misses     40437   40450      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit fd4ee26 into main Apr 26, 2024
3 of 5 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3404/update-trxn-type branch April 26, 2024 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant