Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3387 update data model #3390

Merged
merged 1 commit into from
Feb 1, 2024
Merged

GH-3387 update data model #3390

merged 1 commit into from
Feb 1, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3388

Changes proposed in this pull request:

  • Updates core data model

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 776 lines in your changes are missing coverage. Please review.

Comparison is base (2b3ddf0) 8.14% compared to head (bfeca14) 8.03%.
Report is 31 commits behind head on main.

Files Patch % Lines
...Connect to Web/Logic/WebConnectionController.swift 0.00% 234 Missing ⚠️
...sViewController/TransactionDetailCellBuilder.swift 0.00% 102 Missing ⚠️
Multisig/Logic/Models/EIP712Transformer.swift 0.00% 70 Missing ⚠️
...cureConfig/Sources/SecureConfig/SecureConfig.swift 0.00% 59 Missing ⚠️
... Web/Logic/WebConnectionToSessionTransformer.swift 0.00% 49 Missing ⚠️
...ntroller/ReviewSafeTransactionViewController.swift 0.00% 49 Missing ⚠️
...Connect to Web/Logic/WebConnectionRepository.swift 0.00% 44 Missing ⚠️
...let/UI/SendTransactionToWalletViewController.swift 0.00% 19 Missing ⚠️
...isig/Cross-layer/Configuration/Configuration.swift 0.00% 17 Missing ⚠️
Multisig/App/SceneDelegate.swift 0.00% 16 Missing ⚠️
... and 22 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3390      +/-   ##
========================================
- Coverage   8.14%   8.03%   -0.11%     
========================================
  Files        786     788       +2     
  Lines      43371   43955     +584     
========================================
  Hits        3532    3532              
- Misses     39839   40423     +584     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 3b86378 into main Feb 1, 2024
3 of 5 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3387/update-data branch February 1, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants