Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2886/warning in transactions #3364

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

DmitryBespalov
Copy link
Contributor

@DmitryBespalov DmitryBespalov commented Nov 20, 2023

Handles #2886

Changes proposed in this pull request:

  • Shows warning in the transaction details if:
    • transaction is awaiting signatures or execution AND
    • ( transaction has no confirmations OR
    • confirming addresses are not safe owners OR
    • confirming addresses do not match recovered addresses from confirmation signatures )

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 269 lines in your changes are missing coverage. Please review.

Comparison is base (2b3ddf0) 8.14% compared to head (036b4f5) 8.09%.
Report is 18 commits behind head on main.

❗ Current head 036b4f5 differs from pull request most recent head 852398e. Consider uploading reports for the commit 852398e to get more accurate results

Files Patch % Lines
...sViewController/TransactionDetailCellBuilder.swift 0.00% 102 Missing ⚠️
...cureConfig/Sources/SecureConfig/SecureConfig.swift 0.00% 59 Missing ⚠️
...ntroller/ReviewSafeTransactionViewController.swift 0.00% 49 Missing ⚠️
...isig/Cross-layer/Configuration/Configuration.swift 0.00% 17 Missing ⚠️
...afe Client Gateway Service/SafeNoncesRequest.swift 0.00% 9 Missing ⚠️
...wController/QueuedTransactionsViewController.swift 0.00% 9 Missing ⚠️
...agement/Create Safe/GoogleWeb3AuthLoginModel.swift 0.00% 7 Missing ⚠️
...isig/UI/WalletConnectV2/WalletConnectManager.swift 0.00% 5 Missing ⚠️
Multisig/App/AppDelegate.swift 0.00% 4 Missing ⚠️
Multisig/UI/Assets/Ramper.swift 0.00% 3 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3364      +/-   ##
========================================
- Coverage   8.14%   8.09%   -0.06%     
========================================
  Files        786     788       +2     
  Lines      43371   43651     +280     
========================================
  Hits        3532    3532              
- Misses     39839   40119     +280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 505984d into main Nov 21, 2023
1 of 2 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-2886/warning-in-transactions branch November 21, 2023 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants