gh-2672 Add redeem deadline warning #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biafra23
reviewed
Sep 15, 2022
| @@ -44,6 +46,8 @@ class ClaimedAmountInputCell: UITableViewCell { | |||
| descriptionLabel.text = "Select all tokens or custom amount." | |||
| descriptionLabel.setStyle(.secondary) | |||
|
|
|||
| redeemWarningLabel.setStyle(.footnote2.color(UIColor(hex: "#B2BBC0"))) | |||
There was a problem hiding this comment.
Should this be its own style? smallprint for example?
There was a problem hiding this comment.
It is used in two places already:
There was a problem hiding this comment.
Label style is defined in figma as footnote2 with #B2BBC0 color. Let's revisit this later if we have more usages of this style and color combination. cc @TanyaEfremova
MouazAlzahabi
suggested changes
Sep 15, 2022
Multisig/UI/ClaimToken/ClaimingAmountViewController/ClaimedAmountInputCell.swift
Outdated
Show resolved
Hide resolved
MouazAlzahabi
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #2672
Changes proposed in this pull request: