Gh 2589/distribution screen #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MouazAlzahabi
requested review from
biafra23,
DmitryBespalov and
elgatovital
|
Looks very good. Except for the line between the navbar and the content. Which is not in the design. Is it possible to get the back button and not line between navbar and content? |
biafra23
approved these changes
Sep 6, 2022
elgatovital
reviewed
Sep 6, 2022
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| distributionView.set("Distribution details") { | ||
| //TODO: Show distribution details |
There was a problem hiding this comment.
probably should call a callback so that flow can open the details
There was a problem hiding this comment.
presenting the details will be done from this point when the screen is ready, no need for callback, no?
added 2 commits
September 6, 2022 16:30
# Conflicts: # Multisig.xcodeproj/project.pbxproj # Multisig/UI/ClaimToken/ClaimSafeTokenFlow.swift # Multisig/UI/ClaimToken/LegalDisclaimerViewController.swift # Multisig/UI/ClaimToken/LegalDisclaimerViewController.xib # Multisig/UI/UI Library/String+Highlight.swift
elgatovital
reviewed
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles #2589