Safe Apps Dev Tools Release 5 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: When calling getTxBySafeTxHash every status code is considered success
* Add cla workflow * change cla link in cla github action
* signer wip * signer wip * signer wip * wip * da mvp * dep bump * Signer wip * ethers signer * remove yalc from signer * remove console.logs * change ethersprovider version * add docs * type fixes * utils/poll: remove double increment * dep updatE * doc fix * remove jsonrpc error check logic in checkError
ESLint Summary View Full Report
Report generated by eslint-plus-action |
rmeissner
approved these changes
Feb 18, 2021
germartinez
approved these changes
Feb 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Safe Apps SDK v2.0.0
sdk.txs.getBySafeTxHash(Bug: When calling getTxBySafeTxHash every status code is considered success #96)Safe Apps React SDK v2.0.0
Safe Apps CRA Template v3.0.0
react-scriptsbersionSafe Apps Ethers Provider v0.1.0
I will release everything after this PR gets approved