Fix SafeInfo network type #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
rmeissner
approved these changes
Jan 11, 2021
germartinez
reviewed
Jan 11, 2021
| @@ -59,11 +59,6 @@ export interface SdkInstance { | |||
| } | |||
|
|
|||
| export interface SafeInfo { | |||
| safeAddress: string; | |||
| network: LowercaseNetworks; | |||
rmeissner
reviewed
Jan 12, 2021
packages/safe-apps-sdk/src/types.ts
Outdated
| network: LowercaseNetworks; | ||
| } | ||
|
|
||
| export interface SafeInfoV1 { | ||
| safeAddress: string; | ||
| network: UppercaseNetworks; |
There was a problem hiding this comment.
Why is it not possible to have case insensitive networks?
There was a problem hiding this comment.
Safe interface stores network names in uppercase and we want the type to be a list of constants (e.g "rinkeby", "mainnet", etc)
There was a problem hiding this comment.
I think to have it truly case insensitive we need to switch to chain id :P
mmv08
added a commit
that referenced
this pull request
May 13, 2021
* fix network type: * Revert change to format-dist * update package.json versions * one more pkg version fix for react-sdk * also readme update for react sdk * bump sdk version in react sdk * remove uppercase/lowercase type and use one networks type * dep updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
networkprop ingetSafeInfo