Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #67: Update CRA template/React SDK to use new SDK version #68

Merged
merged 18 commits into from
Dec 16, 2020

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 15, 2020

This PR:

  • Updates CRA template/Safe Apps React SDK to the new version of the SDK
  • Publish both packages under beta versions
  • Rename SafeProvider loading prop to loader. Also, change the behavior of a loader. Now it's displayed only if loader prop is provided and the app is not connected.
  • Export SDK opts from SDK package

Testing:

npx create-react-app my-safe-app --template @gnosis.pm/cra-template-safe-app

Choose the latest beta version

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mmv08 mmv08 marked this pull request as ready for review December 15, 2020 15:51
@mmv08 mmv08 merged commit 843d054 into development Dec 16, 2020
@mmv08 mmv08 deleted the feature/67-update-cra-template-react-hooks-lib branch December 16, 2020 12:20
mmv08 added a commit that referenced this pull request May 13, 2021
* updating react sdk wip

* react sdk updates

* react sdk updates

* export opts from sdk

* useSafe -> useSafeAppsSdk, update typescript config

* bump react sdk to beta version

* set target to es6

* update react sdk

* use new react sdk

* rename back cra template

* fix react sdk dependency

* fix cra template import

* fix wrong prop

* fix hoook dependency

* dep bump

* update react sdk readme

* eremove optional chaining for safe address in the template

* Change order of setState updates in react sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants