Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Convert repository to a monorepo #66

Merged
merged 26 commits into from
Dec 10, 2020
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Dec 9, 2020

This PR converts repository to a monorepo with these packages managed with lerna:

Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... noob question why do we need lerna on top of yarn workspaces?

@mmv08
Copy link
Member Author

mmv08 commented Dec 10, 2020

@rmeissner I don't remember the exact reason now, but I think I had a problem with build/test steps because of scoping issues or something like that, tried to use lerna and it worked 🤷‍♂️

Also judging by this article lerna has better management for packages, leaving yarn workspaces for managing dependencies only.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@mmv08 mmv08 marked this pull request as ready for review December 10, 2020 09:34
@mmv08 mmv08 merged commit 20bcdc7 into development Dec 10, 2020
@mmv08 mmv08 deleted the feature/monorepo-2 branch December 10, 2020 12:37
mmv08 added a commit that referenced this pull request May 13, 2021
* monorepo wip

* monorepo wip

* add react integration

* monorepo wip

* monorepo wip

* build sdk

* jest setup wip

* update package.json for cra temp[late

* jest setup wip

* jest setup wip

* finish jest setup

* add build script for sdk, prettier config, dep bump

* monorepo readme

* move travis.yml to repo root

* update travis to use lerna

* add lerna to global

* README enhancements

* test different action branch

* update node version

* move eslintrc to project root

* add eslint-config-react-app

* add deps for eslint-config-react-app

* eslint fixes

* moar fixes

* moar fixes 2

* use stable version for lint action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants