Add EIP-5792 support to Safe Apps Provider #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c3ab818 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmanu
approved these changes
Oct 30, 2024
| const txs = params[0].calls.map( | ||
| (call: { to?: `0x${string}`; data?: `0x${string}`; value?: `0x${string}`; chainId?: `0x${string}` }) => { | ||
| if (call.chainId !== numberToHex(this.chainId) || !call.to) { | ||
| throw new Error('Invalid call'); |
There was a problem hiding this comment.
We should maybe give more details: e.g. "Invalid calldata: The Safe is not available on the chain"
There was a problem hiding this comment.
I improved the error messages in c3ab818. What do you think?
I agree. Considering it will require quite some changes (and that it is not release-dependant), I'd suggest doing it in a follow up PR. What do you think? |
schmanu
approved these changes
Oct 31, 2024
dasanra
approved these changes
Nov 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With EIP-5792, transaction batching is possible. As it is also possible to batch transactions with our Safe Apps SDK, this includes the relevant JSON-RPC methods to propagate the feature into the Safe Apps Provider.
This implementation has been tested with the experimental implementation of EIP-5792 in viem.
Note: this takes inspiration from the
safe-wallet-webEIP-5792 implementation.wallet_sendCallsThis method is responsible for dispatching the batch. Our implementation maps the incoming "calls" to the relevant
sdk.txs.sendcall, which creates amultiSendcall in our interface.The method should return an ID for fetching the status of the calls. In our case, this is the
safeTxHashof themultiSendtransaction.wallet_getCallsStatusAccepting the aforementioned
id(safeTxHash), this returns the status and receipt(s) of the "calls". By using thesafeTxHash, we fetch the details from the Transaction Service and transaction receipt, mapping the responses to the expected data structure.wallet_showCallsStatusThis should open the "status" in the wallet UI. As our SDK cannot navigate the UI, this is marked as unsupported. (For reference, see the
safe-wallet-webimplementation - navigating to the transaction details.)wallet_getCapabilitiesResponsible for returning the "features" of the wallet, this returns the support for
atomicBatch(batching of transactions) for the current Safe.Changes
wallet_sendCallswallet_getCallsStatuswallet_getCapabilitieswallet_showCallsStatus