Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #21: Allow specifying safe tx gas #52

Merged
merged 11 commits into from
Oct 15, 2020
Merged

Feature #21: Allow specifying safe tx gas #52

merged 11 commits into from
Oct 15, 2020

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Oct 5, 2020

This PR:

*non-compatible with previous versions`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mmv08 mmv08 requested review from rmeissner and germartinez October 7, 2020 13:58
@mmv08 mmv08 marked this pull request as ready for review October 7, 2020 13:58
@mmv08 mmv08 mentioned this pull request Oct 7, 2020
Merged
germartinez
germartinez reviewed Oct 7, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
dasanra
dasanra reviewed Oct 8, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@mmv08 mmv08 requested review from germartinez and dasanra October 8, 2020 12:23
dasanra
dasanra approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@dasanra dasanra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@mmv08 mmv08 merged commit a6c168b into development Oct 15, 2020
@mmv08 mmv08 deleted the feature/21-allow-specifying-safeTxGas branch October 15, 2020 12:22
@hexyls hexyls mentioned this pull request Nov 17, 2020
Merged
@hexyls hexyls mentioned this pull request Dec 7, 2020
Open
mmv08 added a commit that referenced this pull request May 13, 2021
@mmv08
Merge pull request #52 from gnosis/feature/21-allow-specifying-safeTxGas
44755ad 
Feature #21: Allow specifying safe tx gas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasanra dasanra dasanra approved these changes

@germartinez germartinez germartinez approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @germartinez @dasanra